Scripting Helpers is winding down operations and is now read-only. More info→

Expected "End" to close?

Asked by

JustTwiggy 5

4 years ago

Edited 4 years ago

It's a shame I'm already back asking question but does anyone know how to fix this

Full Script

01---------------
02-- Constants--
03----------------
04 
05local DivisionsFrame = script.Parent.Parent.Divisions
06local UniformFrame = script.Parent.Parent.Uniforms
07local MorphDir = game.ReplicatedStorage.Morphs
08local Libs = game.ReplicatedStorage.Libs
09-----------------
10--Main Code---
11-----------------
12 
13for i, v in pairs (MorphDir:GetChildren () ) do
14    local Button = Instance.new("TextButton")
15    Button.Size = UDim2.new(1, 0, 0, 50)
16    Button.BackgroundTransparency = 1
17    Button.Font = "GothamBlack"
18    Button.TextSize = 25
19    Button.TextXAlignment = "Center"
20    Button.TextColor3 = Color3.fromRGB(255, 255, 255)
21 
22    Button.Text = v.Name
23    Button.Parent = DivisionsFrame
24 
25    Button.MouseButton1Click:connect(function ()
26        for i, v2 in pairs (UniformFrame:GetChildren () ) do
27            if v2.ClassName  == "Text Button"  then
28                v2:Destroy()
29            end
30        end
31        end)
32    for  i, v3 in pairs (v:GetChildren () ) do
33            for i, v3 in pairs (MorphDir:GetChildren () ) do
34            local Button = Instance.new("TextButton")
35            Button2.Size = UDim2.new(1, 0, 0, 50)
36            Button2.BackgroundTransparency = 1
37            Button2.Font = "GothamBlack"
38            Button2.TextSize = 25
39            Button2.TextXAlignment = "Center"
40            Button2.TextColor3 = Color3.fromRGB(255, 255, 255) 
41 
42            Button2.Text = v3.Name
43                Button2.Parent = DivisionsFrame 
44        end
45        end
 View all 45 lines...

--It's the end above thats the problem, I think...

Edit- Heres the output

Players.JustTwiggy.PlayerGui.MorphSelection.Scripts.LocalScript:54: Expected 'end' (to close 'do' at line 18), got <eof>; did you forget to close 'do' at line 38?

Does it show a line in the script thats the error? PhantomBrix 40 — 4y

If you click on the error what line line does it take you to? PhantomBrix 40 — 4y

It just takes we to the bottom of the script, where the end is JustTwiggy 5 — 4y

Can you provide the full script? ImTrev 344 — 4y

View all comments (3 more)

I agree, something is wrong at line 38 (according to the error message) but we can't see it. PhantomBrix 40 — 4y

I assume you haven't closed a for loop that started at line 38, try putting an end at the end of said for loop. PhantomBrix 40 — 4y

I put a end there and there is still a problem JustTwiggy 5 — 4y

2 answers

Answered by

ImTrev 344

4 years ago

Edited 4 years ago

With everything and fixed indentations this is what is there. If this is not working as intended please let me know and we can further debug.

01---------------
02-- Constants--
03----------------
04 
05local DivisionsFrame = script.Parent.Parent.Divisions
06local UniformFrame = script.Parent.Parent.Uniforms
07local MorphDir = game.ReplicatedStorage.Morphs
08local Libs = game.ReplicatedStorage.Libs
09-----------------
10--Main Code---
11-----------------
12 
13for i, v in pairs(MorphDir:GetChildren () ) do
14    local Button = Instance.new("TextButton")
15    Button.Size = UDim2.new(1, 0, 0, 50)
16    Button.BackgroundTransparency = 1
17    Button.Font = "GothamBlack"
18    Button.TextSize = 25
19    Button.TextXAlignment = "Center"
20    Button.TextColor3 = Color3.fromRGB(255, 255, 255)
21 
22    Button.Text = v.Name
23    Button.Parent = DivisionsFrame
24 
25    Button.MouseButton1Click:connect(function()
26        for i, v2 in pairs(UniformFrame:GetChildren()) do
27            if v2.ClassName  == "Text Button"  then
28                v2:Destroy()
29            end
30        end
31    end)
32 
33    for  i, v3 in pairs(v:GetChildren()) do
34        for i, v3 in pairs(MorphDir:GetChildren()) do
35            local Button = Instance.new("TextButton")
36            Button.Size = UDim2.new(1, 0, 0, 50)
37            Button.BackgroundTransparency = 1
38            Button.Font = "GothamBlack"
39            Button.TextSize = 25
40            Button.TextXAlignment = "Center"
41            Button.TextColor3 = Color3.fromRGB(255, 255, 255) 
42 
43            Button.Text = v3.Name
44            Button.Parent = DivisionsFrame 
45        end
46    end
47end
 View all 47 lines...

How dare you answer before me Official_DuckyYT 55 — 4y

Answered by

Official_DuckyYT 55

4 years ago

The problem is that you forgot an end at the first for loop, so it should be:

01---------------
02-- Constants--
03----------------
04 
05local DivisionsFrame = script.Parent.Parent.Divisions
06local UniformFrame = script.Parent.Parent.Uniforms
07local MorphDir = game.ReplicatedStorage.Morphs
08local Libs = game.ReplicatedStorage.Libs
09-----------------
10--Main Code---
11-----------------
12 
13for i, v in pairs (MorphDir:GetChildren () ) do
14    local Button = Instance.new("TextButton")
15    Button.Size = UDim2.new(1, 0, 0, 50)
16    Button.BackgroundTransparency = 1
17    Button.Font = "GothamBlack"
18    Button.TextSize = 25
19    Button.TextXAlignment = "Center"
20    Button.TextColor3 = Color3.fromRGB(255, 255, 255)
21 
22    Button.Text = v.Name
23    Button.Parent = DivisionsFrame
24 
25    Button.MouseButton1Click:connect(function ()
26        for i, v2 in pairs (UniformFrame:GetChildren () ) do
27            if v2.ClassName  == "Text Button"  then
28                v2:Destroy()
29            end
30        end
31        end)
32    for  i, v3 in pairs (v:GetChildren () ) do
33            for i, v3 in pairs (MorphDir:GetChildren () ) do
34            local Button2 = Instance.new("TextButton")
35            Button2.Size = UDim2.new(1, 0, 0, 50)
36            Button2.BackgroundTransparency = 1
37            Button2.Font = "GothamBlack"
38            Button2.TextSize = 25
39            Button2.TextXAlignment = "Center"
40            Button2.TextColor3 = Color3.fromRGB(255, 255, 255) 
41 
42            Button2.Text = v3.Name
43                Button2.Parent = DivisionsFrame 
44        end
45        end
46end
 View all 46 lines...

Also fixed another error which you had, and put Button and then tried to define it as Button2

-Ducky

Developer

Youtuber

Expected "End" to close?

2 answers

Answer this question