How would I make my global leaderboard more efficient?

Asked by

4 years ago

So I have made a global leaderboard before, but after a few days, it does not update and too many datastores are added to the queue. I was wondering if you could help me refine and improvise my code to make it more efficient and work every time? Thank You For your time!

Here is the code that I have now:

01local dataStoreService = game:GetService("DataStoreService")
02 
03local players = game:GetService("Players")
04 
05local globalDataStore = dataStoreService:GetOrderedDataStore("Wins")
06 
07local board = workspace.Lobby.GlobalBoard
08 
09local template = board.SurfaceGui.LeaderBoard.Template:Clone()  
10 
11 
12board.SurfaceGui.LeaderBoard.Template:Destroy()
13 
14local function update()
15    for _,child in pairs(board.SurfaceGui.LeaderBoard:GetChildren()) do
16        if child:IsA("Frame") then
17            child:Destroy()
18        end
19    end
20 
21 
22    local success,err = pcall(function()
23 
24    local data = globalDataStore:GetSortedAsync(false,40)
25 
26    local page = data:GetCurrentPage()
27 
28 
29 
30    for rank,plrData in ipairs(page) do
31 
32        local userid = plrData.key
33 
34        local wins = plrData.value  
35 
36        end
37 
38 
39 
40        local new = template:Clone()
41 
42        new.PlrName.Text = players:GetNameFromUserIdAsync(userid)
43 
44        new.PlrAmount.Text = wins   
45 
46        new.LayoutOrder = rank
47 
48        new.Parent = board.SurfaceGui.LeaderBoard
49 
50        end
51 
52 
53    end)
54 
55 
56end
57 
58 
59 
60while true do
61 
62    update()
63 
64    wait(math.random(2,18))
65 
66    spawn(function()
67 
68    for _,plr in pairs(game.Players:GetPlayers()) do
69 
70            globalDataStore:SetAsync(plr.UserId,plr.leaderstats.Wins.Value)
71 
72            wait()
73        end
74 
75    end)
76 
77 
78 
79end
 View all 79 lines...

Change the pairs to ipairs for one. That’s all I can really think of Cynical_Innovation 595 — 4y

How would I make my global leaderboard more efficient?

Answer this question