Scripting Helpers is winding down operations and is now read-only. More info→

Enemy NPC not doing damage. Does this have something to do with debounce?

Asked by

souflee 50

4 years ago

Hey there, I've been scripting for quite a while now, but this is one of the first times I'm asking a question.

In a nutshell, I have an enemy NPC (pathfinding is in another script), the goal is to have a gui with a sword pop up above his head and have it turn red when he begins an attack (here an onTouched function begins to check if the player is blocking the attack or not, so that he does damage), then have it turn green when he's no longer attacking.

This in itsself works fine except for the damage part. I've tried alot of things by now (I've highlighted some of the code I tried), but it just refuses to work. I've also added a BoolValue as debounce, perhaps the problem is in said BoolValue? I'm out of ideas by now. Any help would be greatly appreciated.

01local damageWeapon = script.Parent.Parent.Damage -- .Value(!)
02local canBeDisarmed = script.Parent.Parent.CanBeDisarmed
03local bladeWeapon = script.Parent
04local optionalTouchPartWeapon = script.Parent.Parent.Pole
05local wielderHead = script.Parent.Parent.Parent.Head
06 
07local basicAttackAnim = script.Parent.Parent.Parent.Attack
08local basicAttackAnimPlay = script.Parent.Parent.Parent.Humanoid:LoadAnimation(basicAttackAnim)
09local attacking = false
10--local touched = false
11local canDamage = script.Parent.Parent.CanDamage
12 
13local function warnAttack()
14    wielderHead.AttackUI.SwordIcon.Visible = true
15    wielderHead.AttackUI.SwordIcon.ImageColor3 = Color3.fromRGB(255,0,0)
16    wait(0.2)
17end
18 
19local function basicAttack()
20    --print(canDamage.Value)
21    basicAttackAnimPlay:Play()
22wait(basicAttackAnimPlay.Length)
23    wielderHead.AttackUI.SwordIcon.ImageColor3 = Color3.fromRGB(0,255,0)
24--  wait (math.randomseed(3,5))
25 
26optionalTouchPartWeapon.Touched:Connect(function(hit)
27        if canDamage.Value == true then
28        canDamage.Value = false
29        --  print("attacking")
30        --if touched == false then
31        --touched = true
32 
33        if hit.Parent:FindFirstChild("Humanoid") then
34        --  if attacking == false then
35            --  attacking = true
36                if hit.Parent.Humanoid.IsBlocking.Value == false then
37                    if hit.Parent.Humanoid.NPC.Value == false then
38                    hit.Parent.Humanoid:TakeDamage(damageWeapon.Value)
39                    bladeWeapon.HitSound:Play()
40                wait(2)
41                canDamage.Value = true
42                            -- if target is blocking        
43                    elseif hit.Parent.Humanoid.NPC.Value == false
44                    and hit.Parent.Humanoid.IsBlocking.Value == true  then
45 
46                    bladeWeapon.BlockSound:Play()
47                    bladeWeapon.Sparkles.Enabled = true
48                wait(0.2)
49                    bladeWeapon.Sparkles.Enabled = false
50                        wielderHead.AttackUI.SwordIcon.ImageColor3 = Color3.fromRGB(0,255,0)
51                wait(1)
52                        wielderHead.AttackUI.SwordIcon.Visible = false
53 
54                    --elseif not hit.Parent:FindFirstChild("Humanoid") then
55                    --  canDamage.Value = true
56 
57                    --else
58                    --canDamage.Value = true
59                end
60            end
61        end
62    end
63end)
64end
65 
66while wait(0.5) do
67    if script.Parent.Parent.Parent.EnemyInSight.Value == true then
68repeat
69wait(2)
70    warnAttack()
71    basicAttack()
72until  script.Parent.Parent.Parent.EnemyInSight.Value == false
73        wielderHead.AttackUI.SwordIcon.Visible = false
74    end
75end
 View all 75 lines...

look for any errors by writing /console TheUltimateTNTFriend 109 — 4y

Hey there, thanks for the reply. I'm afraid the output doesn't give any errors as far as I've seen. souflee 50 — 4y

try make it print something after "if hit.Parent.Humanoid.NPC.Value = false then" and if it does print something then must be a error with how ur damaging him TheUltimateTNTFriend 109 — 4y

I'm afraid it doesn't print anything. Really strange. souflee 50 — 4y

I think it's a problem with the debounce or the onTouched function as it doesn't print anything after "if hit.Parent.Humanoid.NPC.Value == false then" souflee 50 — 4y

2 answers

Answered by

wildmanx20 35

4 years ago

I pretty the problem is in the basicAttack function at line 41. The canDamage value only changes if hit.Parent.Humanoid.IsBlocking.Value == false and hit.Parent.Humanoid.NPC.Value == false. If the hit thing is blocking or is a npc then the rest of the code isn't allowed to be run which stops the canDamage from being set to true. So basically move the canDamage outside of the if statements as seen below.

01local damageWeapon = script.Parent.Parent.Damage -- .Value(!)
02local canBeDisarmed = script.Parent.Parent.CanBeDisarmed
03local bladeWeapon = script.Parent
04local optionalTouchPartWeapon = script.Parent.Parent.Pole
05local wielderHead = script.Parent.Parent.Parent.Head
06 
07local basicAttackAnim = script.Parent.Parent.Parent.Attack
08local basicAttackAnimPlay = script.Parent.Parent.Parent.Humanoid:LoadAnimation(basicAttackAnim)
09local attacking = false
10--local touched = false
11local canDamage = script.Parent.Parent.CanDamage
12 
13local function warnAttack()
14    wielderHead.AttackUI.SwordIcon.Visible = true
15    wielderHead.AttackUI.SwordIcon.ImageColor3 = Color3.fromRGB(255,0,0)
16    wait(0.2)
17end
18 
19local function basicAttack()
20    --print(canDamage.Value)
21    basicAttackAnimPlay:Play()
22wait(basicAttackAnimPlay.Length)
23    wielderHead.AttackUI.SwordIcon.ImageColor3 = Color3.fromRGB(0,255,0)
24--  wait (math.randomseed(3,5))
25 
26optionalTouchPartWeapon.Touched:Connect(function(hit)
27        if canDamage.Value == true then
28        canDamage.Value = false
29        --  print("attacking")
30        --if touched == false then
31        --touched = true
32 
33        if hit.Parent:FindFirstChild("Humanoid") then
34        --  if attacking == false then
35            --  attacking = true
36                if hit.Parent.Humanoid.IsBlocking.Value == false then
37                    if hit.Parent.Humanoid.NPC.Value == false then
38                    hit.Parent.Humanoid:TakeDamage(damageWeapon.Value)
39                    bladeWeapon.HitSound:Play()
40 
41                    --{ wait(2) Take From Here
42                    --  canDamage.Value = true
43                     -- if target is blocking     
44 
45                    elseif hit.Parent.Humanoid.NPC.Value == false
46                    and hit.Parent.Humanoid.IsBlocking.Value == true  then
47 
48                    bladeWeapon.BlockSound:Play()
49                    bladeWeapon.Sparkles.Enabled = true
50                wait(0.2)
51                    bladeWeapon.Sparkles.Enabled = false
52                        wielderHead.AttackUI.SwordIcon.ImageColor3 = Color3.fromRGB(0,255,0)
53                wait(1)
54                        wielderHead.AttackUI.SwordIcon.Visible = false
55 
56                    --elseif not hit.Parent:FindFirstChild("Humanoid") then
57                    --  canDamage.Value = true
58 
59                    --else
60                    --canDamage.Value = true
61                end
62            end
63        end
64    end
65    end)
66    wait(2) --And Put here
67    canDamage.Value = true
68end
69 
70while wait(0.5) do
71    if script.Parent.Parent.Parent.EnemyInSight.Value == true then
72repeat
73wait(2)
74    warnAttack()
75    basicAttack()
76until  script.Parent.Parent.Parent.EnemyInSight.Value == false
77        wielderHead.AttackUI.SwordIcon.Visible = false
78    end
79end
 View all 79 lines...

Hey there! Thanks for the informative reply. Do pardon me for my late response, I was asleep when you posted this. I tried out your instructions and did as you said, but the script became very unreliable, it now does damage at seemingly random rather than doing damage when the attack is performed. I possibly (sort of) found a solution. I'll post it down here. Thanks again for your reply. souflee 50 — 4y

Answered by

souflee 50

4 years ago

Alright, lassies and gents - I may have found the solution. I'm not sure what I did, but I'll post the script down below, only problem I currently have with it is that it doesn't register when the player is blocking. Thank you all for your replies (I'm very grateful for that), any more help would be greatly appreciated

001local PathfindingService = game:GetService("PathfindingService")
002math.randomseed(tick())
003 
004--local counter = 1
005 
006local enemySpotted = false
007local CurrentPart = nil
008local MaxInc = 16
009 
010local walkAnim = script.Parent.Walk
011local walkAnimPlay = script.Parent.Humanoid:LoadAnimation(walkAnim)
012 
013local idleAnim = script.Parent.Idle
014local idleAnimPlay = script.Parent.Humanoid:LoadAnimation(idleAnim)
015 
016local holdWeapon = script.Parent.HoldWeapon
017local holdWeaponPlay = script.Parent.Humanoid:LoadAnimation(holdWeapon)
018 
019local followingPath = false
020 
021holdWeaponPlay:Play()
022 
023 
024 
025function findNearestTorso(pos)
026    local list = game.Workspace:GetChildren()
027    local torso = nil
028    local dist = script.Parent.Distance.Value
029    local temp = nil
030    local human = nil
031    local temp2 = nil
032    for x = 1, #list do
033        temp2 = list[x]
034        if (temp2.className == "Model") and (temp2 ~= script.Parent) then
035            temp = temp2:findFirstChild("RightUpperArm")
036            human = temp2:findFirstChild("Humanoid")
037            if (temp ~= nil) and (human ~= nil) and (human.Health > 0) and human["NPC"].Value == false then
038                if (temp.Position - pos).magnitude < dist then
039                    torso = temp
040                    dist = (temp.Position - pos).magnitude
041 
042                end
043            end
044        end
045    end
046    return torso
047end
048 
049 
050local function chaseEnemy()
051    while true do
052        local target = findNearestTorso(script.Parent.UpperTorso.Position)
053        wait(0.1)
054        if target ~= nil then
055        --  print("target found 1")
056            --print(enemySpotted)
057            enemySpotted = true
058                script.Parent.EnemyInSight.Value = true
059 
060            local path = PathfindingService:CreatePath()
061        path:ComputeAsync(script.Parent.HumanoidRootPart.Position, target.Position)
062local waypoints = path:GetWaypoints()
063 
064script.Parent.Humanoid.Running:Connect(function(speed)
065    if speed == 0 then
066    print("I am standing")
067--script.Parent.Humanoid:MoveTo(target.Position, target)
068    end
069            end)
070 
071for _, waypoint in pairs(waypoints) do ---
072 
073script.Parent.Humanoid:MoveTo(waypoint.Position)
074    script.Parent.Humanoid.MoveToFinished:Wait()
075 
076        if waypoint.Action == Enum.PathWaypointAction.Jump then
077       script.Parent.Humanoid:ChangeState(Enum.HumanoidStateType.Jumping)
078    end
079end --script.Parent.Humanoid:MoveTo(target.Position, target)
080            --print(enemySpotted)
081        else
082            --
083            enemySpotted = false
084            script.Parent.EnemyInSight.Value = false
085 
086repeat
087        wait(1)
088        script.Parent.Humanoid:MoveTo(script.Parent.UpperTorso.Position + Vector3.new(math.random(-MaxInc, MaxInc), 0, math.random(-MaxInc, MaxInc)), CurrentPart)
089            idleAnimPlay:Stop()
090            walkAnimPlay:Play()
091        wait(3)
092        walkAnimPlay:Stop()
093        idleAnimPlay:Play()
094 
095        local target = findNearestTorso(script.Parent.UpperTorso.Position)
096        if target ~= nil then
097        --  print("target found 2")
098                    enemySpotted = true
099                        script.Parent.EnemyInSight.Value = true
100 
101        end
102until enemySpotted == true 
103        idleAnimPlay:Stop()
104        walkAnimPlay:Play() 
105        chaseEnemy()
106end
107    end
108    end
109local function repeatStuff()
110    repeat
111        wait(1)
112        script.Parent.Humanoid:MoveTo(script.Parent.UpperTorso.Position + Vector3.new(math.random(-MaxInc, MaxInc), 0, math.random(-MaxInc, MaxInc)), CurrentPart)
113            idleAnimPlay:Stop()
114            walkAnimPlay:Play()
115        --  script.Parent.Humanoid.MoveToFinished:Wait()
116        wait(3)
117            walkAnimPlay:Stop()
118        idleAnimPlay:Play()
119 
120        local target = findNearestTorso(script.Parent.UpperTorso.Position)
121        if target ~= nil then
122            --print("target found 2")
123            enemySpotted = true
124            script.Parent.EnemyInSight.Value = true
125        end
126 
127    until enemySpotted == true 
128        idleAnimPlay:Stop()
129        walkAnimPlay:Play() 
130        chaseEnemy()
131end
132 
133repeatStuff()
 View all 133 lines...

Enemy NPC not doing damage. Does this have something to do with debounce?

2 answers

Answer this question