Why does my code glitch out on the second creation of a lobby?

Asked by

4 years ago

Edited 4 years ago

So i am creating a game called Number Quest Ultra which is a game about maths where you create lobbies/games to challenge people. I was testing today when i came across this weird series of problems which makes no sense

Creating a lobby, leaving it and creating another has some freaky behaviour.

The first creation of the lobby is perfectly normal, it creates the lobby, adds me to it and the UI only shows 1 player which is me

Leaving this lobby also works fine, returns to the select lobby screen and removes the lobby.

The second time round seems to have the funny behaviour, this time creating 2 of me on the players list when there should only be 1.

Leaving this does not close the lobby, but instead adds a player to it somehow.

Repeating this just leads to an increase in the player count

Server Side

001local lobbies = {}
002local lobbyid = 0
003local mapmodule = require(game.ReplicatedStorage.MapModule)
004local ds = game:GetService("DataStoreService"):GetDataStore("MapChoice")
005local ts = game:GetService("TeleportService")
006 
007local lobbytemplate = {
008    ["GameType"] = "",
009    ["Owner"] = "",
010    ["Map"] = "",
011    ["LobbyID"] = 0,
012    ["Players"] = {}
013}
014 
015local function ReturnPlayers(owner,players)
016    local newplayers = players
017    table.insert(newplayers,owner)
018    return newplayers
019end
020 
021game.ReplicatedStorage.CreateGame.OnServerEvent:Connect(function(player,gametype,map)
022    if mapmodule.Maps[map]["Type"] == gametype then
023        if player.Data.Maps:FindFirstChild(map) then
024            lobbyid = lobbyid + 1
025            local newlobby = lobbytemplate
026            newlobby["Owner"] = player.Name
027            newlobby["GameType"] = gametype
028            newlobby["Map"] = map
029            newlobby["LobbyID"] = lobbyid
030            table.insert(lobbies,lobbyid,newlobby)
031            game.ReplicatedStorage.UpdateGameList:FireAllClients(lobbies)
032            game.ReplicatedStorage.UpdatePlayerList:FireClient(player,ReturnPlayers(newlobby["Owner"],newlobby["Players"]))
033            game.ReplicatedStorage.NewLobbyID:FireClient(player,lobbyid)
034        end
035    end
036end)
037 
038game.ReplicatedStorage.LeaveGame.OnServerEvent:Connect(function(player,lobbyid)
039    for i,v in pairs(lobbies) do
040        if v["LobbyID"] == lobbyid then
041            if v["Owner"] == player.Name then
042                for a,b in pairs(v["Players"]) do
043                    game.ReplicatedStorage.LobbyRemoval:FireClient(game.Players[b])
044                end
045                table.remove(lobbies,i)
046                game.ReplicatedStorage.UpdateGameList:FireAllClients(lobbies)
047            else
048                for a,b in pairs(v["Players"]) do
049                    if b == player.Name then
050                        table.remove(v["Players"],a)
051                        for c,d in pairs(v["Players"]) do
052                            game.ReplicatedStorage.UpdatePlayerList:FireClient(game.Players[d],ReturnPlayers(v["Owner"],v["Players"]))
053                        end
054                        game.ReplicatedStorage.UpdateGameList:FireAllClients(lobbies)
055                    end
056                end
057            end
058        end
059    end
060end)
061 
062game.ReplicatedStorage.JoinGame.OnServerEvent:Connect(function(player,lobbyid)
063    for i,v in pairs(lobbies) do
064        if v["LobbyID"] == lobbyid then
065            local maxplayers = 0
066            if v["GameType"] == "Normal" then
067                maxplayers = 4
068            else
069                maxplayers = 16
070            end
071            if (#v["Players"]+1) < maxplayers then
072                table.insert(v["Players"],player.Name)
073                for c,d in pairs(v["Players"]) do
074                    game.ReplicatedStorage.UpdatePlayerList:FireClient(game.Players[d],ReturnPlayers(v["Owner"],v["Players"]))
075                end
076                game.ReplicatedStorage.UpdateGameList:FireAllClients(lobbies)
077            end
078        end
079    end
080end)
081 
082game.ReplicatedStorage.KickPlayer.OnServerEvent:Connect(function(player,lobbyid,kickplayer)
083    for i,v in pairs(lobbies) do
084        if v["LobbyID"] == lobbyid then
085            if v["Owner"] == player.Name then
086                for a,b in pairs(v["Players"]) do
087                    if b == kickplayer then
088                        table.remove(v["Players"],a)
089                        for c,d in pairs(v["Players"]) do
090                            game.ReplicatedStorage.UpdatePlayerList:FireClient(game.Players[d],ReturnPlayers(v["Owner"],v["Players"]))
091                        end
092                        game.ReplicatedStorage.UpdateGameList:FireAllClients(lobbies)
093                    end
094                end
095            end
096        end
097    end
098end)
099 
100game.ReplicatedStorage.StartGame.OnServerEvent:Connect(function(player,lobbyid)
101    for i,v in pairs(lobbies) do
102        if v["LobbyID"] == lobbyid then
103            if v["Owner"] == player.Name and #v["Players"] >= 1 then
104                local players = {}
105                table.insert(players,game.Players[v["Owner"]])
106                for a,b in pairs(v["Players"]) do
107                    table.insert(players,game.Players[b])
108                    ds:SetAsync(game.Players[b].UserId,v["Map"])
109                end
110                local placeidtp
111                if v["GameType"] == "Normal" then
112                    placeidtp = 5185622956
113                else
114                    placeidtp = 5185623208
115                end
116                table.remove(lobbies,i)
117                game.ReplicatedStorage.UpdateGameList:FireAllClients(lobbies)
118                local serverid = ts:ReserveServer(placeidtp)
119                ts:TeleportToPrivateServer(placeidtp,serverid,players)
120            end
121        end
122    end
123end)
124 
125game.Players.PlayerRemoving:Connect(function(player)
126    for i,v in pairs(lobbies) do
127        if v["Owner"] == player.Name then
128            for a,b in pairs(v["Players"]) do
129                game.ReplicatedStorage.LobbyRemoval:FireClient(game.Players[b])
130            end
131            table.remove(lobbies,i)
132            game.ReplicatedStorage.UpdateGameList:FireAllClients(lobbies)
133        else
134            for a,b in pairs(v["Players"]) do
135                if b == player.Name then
136                    table.remove(v["Players"],a)
137                    for c,d in pairs(v["Players"]) do
138                        game.ReplicatedStorage.UpdatePlayerList:FireClient(game.Players[d],ReturnPlayers(v["Owner"],v["Players"]))
139                    end
140                    game.ReplicatedStorage.UpdateGameList:FireAllClients(lobbies)
141                end
142            end
143        end
144    end
145end)
146 
147game.ReplicatedStorage.BuyMap.OnServerEvent:Connect(function(player,map)
148    if player.Data.Coins.Value >= mapmodule.Maps[map]["Cost"] then
149        if player.Data.Maps:FindFirstChild(map) == nil then
150            player.Data.Coins.Value = player.Data.Coins.Value - mapmodule.Maps[map]["Cost"]
151            local newmap = Instance.new("Folder",player.Data.Maps)
152            newmap.Name = map
153        end
154    end
155end)
156 
157local function RequestLobbies()
158    return lobbies
159end
160 
161game.ReplicatedStorage.RequestLobbies.OnServerInvoke = RequestLobbies
 View all 161 lines...

Client Side Lobby UI Manager

01local function UpdateList(listdata)
02    for i,v in pairs(script.Parent:GetChildren()) do
03        if v.ClassName == "Frame" then
04            local isavaiable = false
05            for a,b in pairs(listdata) do
06                if b["LobbyID"] == v.ID.Value then
07                    isavaiable = true
08                end
09            end
10            if isavaiable == false then
11                v:Destroy()
12            else
13                for a,b in pairs(listdata) do
14                    if b["LobbyID"] == v.ID.Value then
15                        if b["GameType"] == "Normal" then
16                            v.Players.Text =(#b["Players"]+1).."/4 Players"
17                        else
18                            v.Players.Text =(#b["Players"]+1).."/16 Players"
19                        end
20                    end
21                end
22            end
23        end
24    end
25    for i,v in pairs(listdata) do
26        local isfound = false
27        for a,b in pairs(script.Parent:GetChildren()) do
28            if b.ClassName == "Frame" then
29                if b.ID.Value == v["LobbyID"] then
30                    isfound = true
31                end
32            end
33        end
34        if isfound == false then
35            local clone = game.ReplicatedStorage.LobbyFrame:Clone()
36            clone.ID.Value = v["LobbyID"]
37            clone.Owner.Value = v["Owner"]
38            clone.OwnerText.Text = v["Owner"].."'s Game"
39            clone.Map.Text = v["Map"]
40            clone.Mode.Text = v["GameType"]
41            if v["GameType"] == "Normal" then
42                clone.Players.Text = (#v["Players"]+1).."/4 Players"
43            else
44                clone.Players.Text = (#v["Players"]+1).."/16 Players"
45            end
46            clone.Parent = script.Parent
47        end
48    end
49end
50 
51UpdateList(game.ReplicatedStorage.RequestLobbies:InvokeServer())
52 
53game.ReplicatedStorage.UpdateGameList.OnClientEvent:Connect(function(lobbies)
54    UpdateList(lobbies)
55end)
 View all 55 lines...

Client Side Player List Manager

01local function UpdateList(playerlist)
02    for i,v in pairs(script.Parent:GetChildren()) do
03        if v.Name == "PlayerFrame" then
04            v:Destroy()
05        end
06    end
07    for i,v in pairs(playerlist) do
08        local clone = game.ReplicatedStorage.PlayerFrame:Clone()
09        clone.PlayerName.Text = v
10        clone.Parent = script.Parent
11    end
12end
13 
14game.ReplicatedStorage.UpdatePlayerList.OnClientEvent:Connect(function(playerlist)
15    UpdateList(playerlist)
16end)

I am truly confused and just can't understand why this happens

I assume one of your if statements is returning false, perhaps use some print and warn statements to detect if that is the case zomspi 541 — 4y

Why does my code glitch out on the second creation of a lobby?

Answer this question