Why isn't my code working but no error and it should be correct code?

Asked by

4 years ago

I am making a piggy inspired game from scratch will the help of my friend, and he is the builder. I am the programmer of the game, and I am having some difficulties in my system that detects if the game is over or not. If the timer runs out it is over. If everyone dies or leaves the game, the round is over. If the slayer dies or leaves the game, the round is over. The timer part works completely fine, but the other 2 options work and don’t work. They work very well if you are doing 1 player, but not that good when multiple players get selected. I have gone over my code a bunch of times, and I even tried making it double-check, and still nothing. Voting works fine, but this glitch only happens when a player is selected and not a bot. Here is my round system code:

001while true do
002    for i, v in pairs(game.Players:GetChildren()) do
003        v.Character.Humanoid.Health = v.Character.Humanoid.MaxHealth -- Makes sure the player's health is full
004    end
005    for i = 45, 0, -1 do
006        game.ReplicatedStorage.Status.Value = "<ContainerHorizontalAlignment=Center><AnimateStepFrequency=0>Intermission: <AnimateStyle=Fade><AnimateStyleTime=0.25><Color=Green>" .. i  -- I used rich text module made by defaultio
007        wait(1)
008    end
009    local slayer
010    local gameOver = false
011    local slayerLeft = false
012    local players = game.Players:GetChildren() -- a table listing all of the players that we will put into the round
013    local chosenMode = "Player"
014    local numPlayers = #game.Players:GetChildren() -- the number of players
015    for i, v in pairs(players) do -- Doesn't add the player to the round if they are still loading
016        if not v.Character then
017            numPlayers = numPlayers - 1
018            table.remove(players, i)
019        end
020    end
021    if numPlayers == 1 or #players == 1 then -- Automatically chooses bot if only 1 player in the server
022        chosenMode = "Bot"
023    else
024        if #game.ReplicatedStorage.BotVote:GetChildren() > #game.ReplicatedStorage.PlayerVote:GetChildren() then
025            chosenMode = "Bot"
026        else
027            chosenMode = "Player"
028            numPlayers = numPlayers - 1
029        end
030    end
031    if chosenMode == "Player" then
032        slayer = game.Players:GetChildren()[math.random(1, #game.Players:GetChildren())] -- Choosing slayer is not the problem btw
033    else
034        slayer = game.ServerStorage.Bots.Bot:Clone()
035    end
036    for i, v in pairs(players) do
037        if v.Name == slayer.Name then -- Removes the slayer from the player table
038            table.remove(players, i)
039        end
040        v.Character.Humanoid.WalkSpeed = 16 + v.ExtraSpeed.Value -- Faster speed gamepass thing
041        v.Character.Humanoid.Died:Connect(function() -- if player died, it will remove them from the players table
042            table.remove(players, i)
043            numPlayers = numPlayers - 1
044            print(v, "Died!")
045            if v.Character:FindFirstChildOfClass("Tool") then -- puts the tools back where they found it.
046                game.ServerStorage.Tools:FindFirstChild(v.Character:FindFirstChildOfClass("Tool").Name).Parent = game.Workspace.CurrentMap.Keys
047                v.Character:FindFirstChildOfClass("Tool"):Destroy()
048            end
049            if v.Backpack:FindFirstChildOfClass("Tool") then
050                game.ServerStorage.Tools:FindFirstChild(v.Backpack:FindFirstChildOfClass("Tool").Name).Parent = game.Workspace.CurrentMap.Keys
051                v.Backpack:FindFirstChildOfClass("Tool"):Destroy()
052            end
053        end)
054    end
055    game.ReplicatedStorage.Escape.OnServerEvent:Connect(function(player) -- if player escapes, they will be removed from the players table
056        print(player, "Escaped")
057        numPlayers = numPlayers - 1
058        game.BadgeService:AwardBadge(player.UserId, 2124534311)
059        player.Points.Value = player.Points.Value + (35 * player.Multiplier.Value)
060        for i, v in pairs(players) do
061            if v == player then
062                table.remove(players, i)
063            end
064        end
065    end)
066    game.Players.PlayerRemoving:Connect(function(player)
067        if player == slayer then -- resets game if slayer left
068            players = {}
069            gameOver = true
070            slayerLeft = true
071        else
072            for i, v in pairs(players) do
073                if v == player then
074                    table.remove(players, i)
075                end
076            end
077        end
078    end)
079    if chosenMode == "Player" then -- resets the game if the slayer died
080        slayer.Character.Humanoid.Died:Connect(function()
081            gameOver = true
082            slayerLeft = true
083        end)
084    end
085    game.ReplicatedStorage.Status.Value = "<ContainerHorizontalAlignment=Center><AnimateStepFrequency=0.05><AnimateStyle=Fade><AnimateStyleTime=0.25><Color=Red>" .. slayer.Name .. "<Color=/> has been selected as<Color=Red> Slayer!<Color=/>" -- some more rich text
086    wait(5)
087    local map = game.ServerStorage.Maps.House:Clone()
088    map.Parent = game.Workspace
089    map.Name = "CurrentMap"
090    game.ReplicatedStorage.Status.Value = "<ContainerHorizontalAlignment=Center><AnimateStepFrequency=0.05><AnimateStyle=Fade><AnimateStyleTime=0.25>Loading Map..."
091    wait(5)
092    game.ReplicatedStorage.Fade:FireAllClients(true)
093    wait(2)
094    game.ReplicatedStorage.Fade:FireAllClients(false)
095    game.ReplicatedStorage.HideShop:FireAllClients(false)
096    wait(0.1)
097    if chosenMode == "Player" then
098        game.ReplicatedStorage.Backpack:FireClient(slayer, false) -- hides the slayer's backpack
099    end
100    for i, v in pairs(players) do
101        game.ReplicatedStorage.Intro:FireClient(v)
102    end
103    game.ReplicatedStorage.Intro:FireClient(slayer)
104    for i, v in pairs(players) do -- for the intro
105        if v.Character then
106            pcall(function()
107                v.Character:SetPrimaryPartCFrame(CFrame.new(266.253, -29.26, -93.261) * CFrame.Angles(0, math.rad(90), 0))
108            end)
109        end
110    end
111    wait(30)
112    game.Workspace.GameTimeMusic:Play()
113    if chosenMode == "Player" then -- changes player to the slayer skin
114        skin = game.ServerStorage.Skins:FindFirstChild(slayer.Equip.Value):Clone()
115        skin.Name = slayer.Name
116        slayer.Character = skin
117        skin.Parent = game.Workspace
118        slayer.Character:SetPrimaryPartCFrame(CFrame.new(339.263, 4, 205.29))
119        skin.Humanoid.WalkSpeed = 16 + slayer.ExtraSpeed.Value
120    end
121    for i, v in pairs(players) do
122        if v.Name ~= slayer.Name then
123            pcall(function()
124                v.Character:SetPrimaryPartCFrame(map.Spawn.CFrame)
125            end)
126        end
127    end
128    game.ReplicatedStorage.CurrentSlayer.Value = slayer.Name
129    for i = 480, 0, -1 do -- timer system
130        local timer = math.floor(i / 60) .. ":" .. i % 60
131        if i % 60 < 10 then
132            timer = math.floor(i / 60) .. ":0" .. i % 60
133        end
134        if i == 450 then
135            if chosenMode == "Player" then
136                slayer.Character:SetPrimaryPartCFrame(map.Spawn.CFrame)
137            else
138                slayer.Parent = game.Workspace
139                slayer:SetPrimaryPartCFrame(map.Spawn.CFrame)
140            end
141        end
142        game.ReplicatedStorage.Status.Value = "<ContainerHorizontalAlignment=Center><AnimateStepFrequency=0>Game Time: <AnimateStyle=Fade><AnimateStyleTime=0.25><Color=Green>" .. timer
143        wait(1)
144        if #players == 0 then
145            gameOver = true
146        end
147        if numPlayers == 0 then
148            gameOver = true
149        end
150        if gameOver then -- resets game if gameOver is set to true
151            break
152        end
153    end
154    game.Workspace.GameTimeMusic:Stop()
155    game.ReplicatedStorage.Status.Value = "<ContainerHorizontalAlignment=Center><AnimateStepFrequency=0.05><AnimateStyle=Fade><AnimateStyleTime=0.25>Game Over!"
156    wait(3)
157    game.ReplicatedStorage.Backpack:FireAllClients(true)
158    game.Workspace.TrapsPlacement:ClearAllChildren()
159    map:Destroy()
160    if not slayerLeft then
161        if chosenMode == "Player" then -- turns player back to normal if slayer
162            slayer:LoadCharacter()
163            skin:Destroy()
164        else
165            slayer:Destroy()
166        end
167    end
168    game.ReplicatedStorage.CurrentSlayer.Value = ""
169    game.ReplicatedStorage.HideShop:FireAllClients(true)
170    for i, v in pairs(players) do -- teleports players back to the lobby
171        if v then
172            v.Character:MoveTo(game.Workspace:FindFirstChild("SpawnLocation" .. math.random(1, 3)).Position)
173        end
174    end
175    game.ReplicatedStorage.BotVote:ClearAllChildren()
176    game.ReplicatedStorage.PlayerVote:ClearAllChildren()
177    game.ServerStorage.Tools:ClearAllChildren()
178end
 View all 178 lines...

I just cannot figure out why it doesn’t work. I sometimes found that if a player dies it sometimes doesn’t do anything. Is the script not efficient or is it an error? I can’t seem to know!

nice code script milker. just tell us the line it stops on. lmao iuclds 720 — 4y

it doesn't stop. there are no errors but it still doesn't work MrTumbleWede 5 — 4y

Why isn't my code working but no error and it should be correct code?

Answer this question