Scripting Helpers is winding down operations and is now read-only. More info→

[SOLVED] My datastore isn't working. Too much added to queue?

Asked by

Lightning_Game27 232

4 years ago

Edited 4 years ago

So I have a GlobalLeaderboard script that is supposed to order the player names according to the number of wins they have.

The script below is located in ServerScriptService.

My issue is that my output says that I have too many datastore requests and if more keep coming, the older ones get deleted.

How do I efficiently stop this?

01local dataStoreService = game:GetService("DataStoreService")
02 
03local players = game:GetService("Players")
04 
05 
06 
07local globalDataStore = dataStoreService:GetOrderedDataStore("Wins")
08 
09local board = workspace.Lobby.GlobalBoard
10 
11local template = board.SurfaceGui.LeaderBoard.Template:Clone()  
12 
13board.SurfaceGui.LeaderBoard.Template:Destroy()
14 
15 
16local function update()
17 
18    for _,child in pairs(board.SurfaceGui.LeaderBoard:GetChildren()) do
19 
20        if child:IsA("Frame") then
21            child:Destroy()
22        end
23    end
24 
25    local success,err = pcall(function()
26 
27    local data = globalDataStore:GetSortedAsync(false,40)
28 
29    local page = data:GetCurrentPage()
30 
31 
32    for rank,plrData in ipairs(page) do
33 
34        local userid = plrData.key
35 
36        local wins = plrData.value
37 
38        if rank < 3 then
39            local npc = workspace:FindFirstChild(rank)
40                if npc then
41                    npc.UserId.Value = userid
42            end
43        end
44 
45        local new = template:Clone()
46 
47        new.PlrName.Text = players:GetNameFromUserIdAsync(userid)
48 
49        new.PlrAmount.Text = wins   
50 
51        new.LayoutOrder = rank
52 
53        new.Parent = board.SurfaceGui.LeaderBoard
54        end
55    end)
56end
57 
58while true do
59    update()
60    wait(math.random(2,5))
61    spawn(function()
62 
63        for _,plr in pairs(game.Players:GetPlayers()) do
64            globalDataStore:SetAsync(plr.UserId,plr.leaderstats.Wins.Value)
65            wait()
66        end
67    end)
68end
 View all 68 lines...

There are too many spaces in your script which makes it hard to read -_- try formatting it. Coperncius 0 — 4y

ok sorry, will edit it right now! Lightning_Game27 232 — 4y

there, i made it better Lightning_Game27 232 — 4y

1 answer

Answered by

centraltrains 60

4 years ago

This just means you are updating the datastore too frequently.

In your while true do loop you use

`1`	`wait(math.random(2,5))`

But Set has a limit of 50 + (10*playerCount) per minute (https://developer.roblox.com/en-us/articles/Datastore-Errors).

You'd be best off achieving this by saving less frequently, i.e. every minute. The general advise on when to save is, when the player leaves (using Players.PlayerRemoving), when the game shutdowns (using BindToClose) and about every minute (using a loop like you have, but less frequently).

https://developer.roblox.com/en-us/api-reference/event/Players/PlayerRemoving https://developer.roblox.com/en-us/api-reference/function/DataModel/BindToClose

If you really need to update that frequently, you might be able to get away with just saving when .Changed is fired on the value.

[SOLVED] My datastore isn't working. Too much added to queue?

1 answer

Answer this question