Scripting Helpers is winding down operations and is now read-only. More info→

Data not loading?! (It works fine besides it not loading)

Asked by

iiDev_Hunt3r 64

4 years ago

Edited 4 years ago

The data script below works all well but refuses to load. It doesn't show any errors in output! Any idea whats going on? lmk thx

The issue is that the data wont load correctly! pls help

001local data = require(script.DataModule)
002 
003local DSS = game:GetService("DataStoreService")
004local statSave = DSS:GetDataStore("stats_Test2020")
005local settingSave = DSS:GetDataStore("settings_Test2020")
006local careerSave = DSS:GetDataStore("careers_Test2020")
007 
008--ughh its not working
009 
010game.Players.PlayerAdded:Connect(function(player)
011    local key = "Data-ID"..player.UserId
012 
013    local statData = statSave:GetAsync(key)
014    local settingData = settingSave:GetAsync(key)
015    local careerData = careerSave:GetAsync(key)
016 
017    local StatsFolder = Instance.new("Folder", player)
018    local SettingsFolder = Instance.new("Folder", player)
019    local CareersFolder = Instance.new("Folder", player)
020 
021    StatsFolder.Name = "leaderstats"
022    SettingsFolder.Name = "Settings"
023    CareersFolder.Name = "Careers"
024 
025    -----
026 
027    for i,stats in pairs(data["Stats"]) do
028        local thing = Instance.new("IntValue", StatsFolder) 
029        thing.Name = tostring(stats)
030        thing.Value = 0
031    end
032    for i,setting in pairs(data["Settings"]) do
033        local thing = Instance.new("BoolValue", SettingsFolder)
034        thing.Name = tostring(setting)
035    end
036    for i,career in pairs(data["Careers"]) do
037        local thing = Instance.new("BoolValue", CareersFolder)
038        thing.Name = tostring(career)
039    end
040 
041    if statData then
042        for i,v in pairs(StatsFolder:GetChildren()) do
043            v.Value = statData[i]
044        end
045    else
046        local StatTable = {}
047 
048        for i,v in pairs(StatsFolder:GetChildren()) do
049            table.insert(StatTable, v.Value)
050        end
051 
052        statSave:SetAsync(key, StatTable)
053    end
054 
055    if settingData then
056        for i,v in pairs(SettingsFolder:GetChildren()) do
057            v.Value = settingData[i]
058        end
059    else
060        local SettingsTable = {}
061 
062        for i,v in pairs(SettingsFolder:GetChildren()) do
063            table.insert(SettingsTable, v.Value)
064        end
065 
066        settingSave:SetAsync(key, SettingsTable)
067    end
068 
069    if careerData then
070        for i,v in pairs(CareersFolder:GetChildren()) do
071            v.Value = careerData[i]
072        end
073    else
074        local CareersTable = {}
075 
076        for i,v in pairs(CareersFolder:GetChildren()) do
077            table.insert(CareersTable, v.Value)
078        end
079 
080        settingSave:SetAsync(key, CareersTable)
081    end
082end)
083 
084game.Players.PlayerRemoving:Connect(function(player)
085    local key = "Data-ID"..player.UserId
086    local Stats = player.leaderstats
087    local Settings = player.Settings
088    local Careers = player.Careers
089 
090    local statsTable = {}
091    local settingsTable = {}
092    local careersTable = {}
093 
094    for i,v in pairs(Stats:GetChildren()) do
095        table.insert(statsTable, v.Value)
096    end
097    for i,v in pairs(Settings:GetChildren()) do
098        table.insert(settingsTable, v.Value)
099    end
100    for i,v in pairs(Careers:GetChildren()) do
101        table.insert(careersTable, v.Value)
102    end
103 
104    statSave:SetAsync(key, statsTable)
105    settingSave:SetAsync(key, settingsTable)
106    careerSave:SetAsync(key, careersTable)
107end)
 View all 107 lines...

i had trouble like this before and how i solved it was just adding pcalls HappyTimIsHim 652 — 4y

it seems like ur making int and boolvalues looping through the saved data. if there's nothing inside then it wouldn't create anything i guess HappyTimIsHim 652 — 4y

2 answers

Answered by

AntiWorldliness 868

4 years ago

Edited 4 years ago

I just skimmed through your script, but you said everything was working fine except for the data not saving. I know a lot of people have this problem too. Check out this article. Hopefully this answers your question. Basically, the server may shut down before the last player leaves or if you're playing Solo in the Studio, thus not being able to complete all the functions. To fix that, use BindToClose. Place the function that you want to run before the server shuts down, inside of the BindToClose function. The function should be completed less than 30 seconds at most before the server shuts down.

01game:BindToClose(function() -- Runs the PlayerRemoving function before server shuts down
02    for i, player in pairs(game.Players:GetPlayers()) do
03 
04    local key = "Data-ID"..player.UserId
05    local Stats = player.leaderstats
06    local Settings = player.Settings
07    local Careers = player.Careers
08 
09    local statsTable = {}
10    local settingsTable = {}
11    local careersTable = {}
12 
13    for i,v in pairs(Stats:GetChildren()) do
14        table.insert(statsTable, v.Value)
15    end
16    for i,v in pairs(Settings:GetChildren()) do
17        table.insert(settingsTable, v.Value)
18    end
19    for i,v in pairs(Careers:GetChildren()) do
20        table.insert(careersTable, v.Value)
21    end
22 
23    statSave:SetAsync(key, statsTable)
24    settingSave:SetAsync(key, settingsTable)
25    careerSave:SetAsync(key, careersTable)
26end
27end)
 View all 27 lines...

tysm ill try this iiDev_Hunt3r 64 — 4y

Its still not working xD iiDev_Hunt3r 64 — 4y

Make sure that you did not delete the PlayerRemoving function. Simply keep your original script, but then add this one at the end. AntiWorldliness 868 — 4y

It works now xD But datas being throttled iiDev_Hunt3r 64 — 4y

Answered by

kie1605 0

4 years ago

I had this problem for a while and i figured Values inside of player when updated don't update for the server(or something like that idk). the way i worked around this was i had a remote send the data from a local script to the server when it was called.

example...

Client:

1local remote = <remote>
2 
3local data = <value thingy in player>.Value
4 
5local function save()
6    remote:FireServer(data)
7end

Server:

1local remote = <remote>
2 
3remote.OnServerEvent:Connect(function(player, data)
4    Datastore:SetAsync(key, data)
5end)

idk but it works

i- i know that xD i am using a remote... iiDev_Hunt3r 64 — 4y

The refuses to load/save iiDev_Hunt3r 64 — 4y

? i see not a remote kie1605 0 — 4y

You dont need a remote for data... you need it to change stats but im trying to load data! Who uses remotes to load data xD iiDev_Hunt3r 64 — 4y

Data not loading?! (It works fine besides it not loading)

2 answers

Answer this question