Why is my ray cast gun with remote events not working?

Asked by

4 years ago

I have created a ray cast gun using the laser gun wiki and added reload functions, animations, ect. But recently I noticed that the enemies would be stuck on 0 or lower health and not dying. I searched it up and one thing said that the lag could be from the fact that it is all client sided and the server doesn't realize the zombie is dead. So I created a new script using remote events, a local script, and a server script, but when I try to shoot it the ray detects the player even though I set it to ignore the player. Please tell me what I did wrong and if I'm using remote events right, just started coding about 2 months ago. The local script is creating the ray and beam is created but no damage is dealt.

Local Script:

01--Variables---
02local tool = script.Parent
03local player = game:GetService("Players").LocalPlayer
04local firePart =  script.Parent:WaitForChild("firePart")
05local canShoot = true
06local UserInputService = game:GetService("UserInputService")
07local reloading = false
08local reloadNoti = player.PlayerGui.gunGui.Frame.reload
09local character = player.Character
10local HRP = character.HumanoidRootPart
11local light = script.Parent.firePart.SpotLight
12local ReplicatedStorage = game:GetService("ReplicatedStorage")
13local shotEvent = ReplicatedStorage.Events:WaitForChild("Shot")
14local ignoreList = {character}
15 
16--Sounds--
17local hitSound = script.Hit
18local critSound = script.Crit
19local shotSound = script.Shot
20local reloadSound = script.Reloading
21 
22--GunSettings--
23local fireRate = .1
24local dmg = 20
25local critDmg = 30
26local magSize = script.magSize
27local ammoCount = script.AmmoCount
28local reloadSpeed = 2
29 
30--Shooting--
31tool.Equipped:Connect(function(mouse)
32    print(player.Name.." equipped the Magnum!")
33 
34    mouse.Button1Down:Connect(function()
35        if canShoot and ammoCount.Value > 0 and (reloading ~= true) then
36        shotSound:Play()
37        light.Enabled = true
38        ammoCount.Value = ammoCount.Value - 1
39        canShoot = false
40 
41        local ray = Ray.new(firePart.CFrame.p, HRP.CFrame.lookVector * 300)
42 
43        local part, position = workspace:FindPartOnRay(ray, character, false, true)
44 
45        local beam = Instance.new("Part", workspace)
46        beam.BrickColor = BrickColor.new("New Yeller")
47        beam.FormFactor = "Custom"
48        beam.Material = "Neon"
49        beam.Transparency = 0.25
50        beam.Anchored = true
51        beam.Locked = true
52        beam.CanCollide = false
53 
54        local distance = (firePart.CFrame.p - position).magnitude
55        beam.Size = Vector3.new(0.1, 0.1, distance)
56        beam.CFrame = CFrame.new(firePart.CFrame.p, position) * CFrame.new(0, 0, -distance / 2)
57 
58 
59        game:GetService("Debris"):AddItem(beam, 0.1)
60 
61                wait(fireRate)
62                canShoot = true
63                light.Enabled = false
64 
65        if part then
66            local playerH = game.Players.LocalPlayer.Character.Humanoid
67            local hit = part.Parent:FindFirstChild("Humanoid")
68 
69            if not hit then
70                hit = part.Parent.Parent:FindFirstChild("Humanoid")
71            end
72 
73            if hit then
74                shotEvent:FireServer(hit)
75        end
76        end
77        end
78        end)
79 
80    --reload--
81    UserInputService.InputBegan:connect(function(inputObject, gameProcessedEvent)
82    if inputObject.KeyCode == Enum.KeyCode.R and ammoCount.Value < magSize.Value and (reloading ~= true) then
83        reloading = true
84        reloadNoti.Text = "RELOADING..."
85        reloadSound:Play()
86 
87        wait(reloadSpeed)
88        ammoCount.Value = magSize.Value
89        wait()
90        reloadNoti.Text = ""
91        reloading = false
92 
93 
94end
95end)
96end)
 View all 96 lines...

Server:

01local ReplicatedStorage = game:GetService("ReplicatedStorage")
02local hitSound = script.Hit
03local critSound = script.Crit
04local shotSound = script.Shot
05local reloadSound = script.Reloading
06 
07local shotEvent = ReplicatedStorage.Events:WaitForChild("Shot")
08 
09local function hasBeenShot(hit)
10    local rand = math.random(4)
11                if rand == 4 then
12                critSound:Play()
13                print("hit.Name")
14                print("critical")
15                hit.Parent.Humanoid.Health = hit.Parent.Humanoid.Health - 100
16                        else
17                hitSound:Play()
18                print(hit.Name)
19                hit.Parent.Humanoid.Health = hit.Parent.Humanoid.Health - 100
20            end
21            end
22 
23shotEvent.OnServerEvent:Connect(hasBeenShot)
 View all 23 lines...

Working old local script:

001--Variables---
002local tool = script.Parent
003local player = game:GetService("Players").LocalPlayer
004local firePart =  script.Parent:WaitForChild("firePart")
005local canShoot = true
006local UserInputService = game:GetService("UserInputService")
007local reloading = false
008local reloadNoti = player.PlayerGui.gunGui.Frame.reload
009local character = player.Character
010local HRP = character.HumanoidRootPart
011local light = script.Parent.firePart.SpotLight
012 
013--Sounds--
014local hitSound = script.Hit
015local critSound = script.Crit
016local shotSound = script.Shot
017local reloadSound = script.Reloading
018 
019--GunSettings--
020local fireRate = .1
021local dmg = 20
022local critDmg = 30
023local magSize = script.magSize
024local ammoCount = script.AmmoCount
025local reloadSpeed = 2
026 
027--Shooting--
028tool.Equipped:Connect(function(mouse)
029    print(player.Name.." equipped the Magnum!")
030 
031    mouse.Button1Down:Connect(function()
032        if canShoot and ammoCount.Value > 0 and (reloading ~= true) then
033        shotSound:Play()
034        light.Enabled = true
035        ammoCount.Value = ammoCount.Value - 1
036        canShoot = false
037 
038        local ray = Ray.new(firePart.CFrame.p, HRP.CFrame.lookVector * 300)
039        local part, position = workspace:FindPartOnRay(ray, player.Character, false, true)
040 
041        local beam = Instance.new("Part", workspace)
042        beam.BrickColor = BrickColor.new("New Yeller")
043        beam.FormFactor = "Custom"
044        beam.Material = "Neon"
045        beam.Transparency = 0.25
046        beam.Anchored = true
047        beam.Locked = true
048        beam.CanCollide = false
049 
050        local distance = (firePart.CFrame.p - position).magnitude
051        beam.Size = Vector3.new(0.1, 0.1, distance)
052        beam.CFrame = CFrame.new(firePart.CFrame.p, position) * CFrame.new(0, 0, -distance / 2)
053 
054 
055        game:GetService("Debris"):AddItem(beam, 0.1)
056 
057                wait(fireRate)
058                canShoot = true
059 
060        light.Enabled = false
061        if part then
062            local humanoid = part.Parent:FindFirstChild("Humanoid")
063 
064            if not humanoid then
065                humanoid = part.Parent.Parent:FindFirstChild("Humanoid")
066            end
067 
068            if humanoid then
069                local rand = math.random(4)
070                if rand == 4 then
071                humanoid:TakeDamage(critDmg)
072                critSound:Play()
073                print("crit")
074 
075                        else
076                    humanoid:TakeDamage(dmg)
077                    hitSound:Play()
078 
079 
080            end
081 
082        end
083    end
084    end
085    end)
086 
087    --reload--
088    UserInputService.InputBegan:connect(function(inputObject, gameProcessedEvent)
089    if inputObject.KeyCode == Enum.KeyCode.R and ammoCount.Value < magSize.Value and (reloading ~= true) then
090        reloading = true
091        reloadNoti.Text = "RELOADING..."
092        reloadSound:Play()
093 
094        wait(reloadSpeed)
095        ammoCount.Value = magSize.Value
096        wait()
097        reloadNoti.Text = ""
098        reloading = false
099    end
100    end)
101 
102end)
 View all 102 lines...

Try using hit.Parent.Humanoid:TakeDamage(100) mixgingengerina10 223 — 4y

https://developer.roblox.com/en-us/api-reference/function/WorldRoot/FindPartOnRayWithIgnoreList Brandon1881 721 — 4y

I get "13:14:48.312 - Humanoid is not a valid member of Players 13:14:48.314 - Stack Begin 13:14:48.315 - Script 'Players.wildmanx20.Backpack.Magnum.ServerMain', Line 18 - function hasBeenShot 13:14:48.316 - Stack End". As the ray is detecting the player even though i told it not too in the local script Line 43 wildmanx20 35 — 4y

responding to mixginggengerina10 ^^ wildmanx20 35 — 4y

View all comments (3 more)

@Brandon1881 How would I use that? I replaced FindPartOnRay with it but i didn't work. i'm guessing I did it wrong. I got " 13:24:19.917 - Unable to cast value to Objects 13:24:19.918 - Stack Begin 13:24:19.919 - Script 'Players.wildmanx20.Backpack.Magnum.ClientMain', Line 43 13:24:19.920 - Stack End" wildmanx20 35 — 4y

Can you try and see what hit prints? mixgingengerina10 223 — 4y

It prints my username wildmanx20 35 — 4y

Why is my ray cast gun with remote events not working?

Answer this question