Scripting Helpers is winding down operations and is now read-only. More info→

Player doesn't recieve item after being given?

Asked by

kjduck 0

4 years ago

ToolGivingSystem: (Script in ServerScriptService)

01local groupId = 6301077
02local ToolGive = Instance.new("RemoteEvent", game.ReplicatedStorage)
03ToolGive.Name = "GivePlayerTools"
04 
05function giveTools(plr, toolFolder, givePlayer)
06    print("Fired")
07    if plr:GetRankInGroup(groupId) > -1 then
08        print("Giving tools")
09        local tools = toolFolder:GetChildren()
10        for _, tool in pairs (tools) do
11            tool.Parent = givePlayer.Backpack
12            print("Given "..tool.Name)
13        end
14        toolFolder:Destroy()
15    end
16end
17 
18ToolGive.OnServerEvent:Connect(giveTools)

ToolGivingLocal: (LocalScript in StarterPlayerScripts)

01local gui = script:WaitForChild("ToolGiver")
02local toolButton = script:WaitForChild("Tool")
03local groupId = 6301077
04local plr = game.Players.LocalPlayer
05local mouse = plr:GetMouse()
06local givingEvent = game.ReplicatedStorage:WaitForChild("GivePlayerTools")
07 
08if plr:GetRankInGroup(groupId) > 254 then
09    wait(1)
10    script:Destroy()
11end
12 
13mouse.Button1Down:Connect(function()
14    local target = mouse.Target
15    if mouse.target ~= nil and target.Parent:FindFirstChild("HumanoidRootPart") then
16        local givingPlr = game.Players:GetPlayerFromCharacter(target.Parent)
17        local tools = plr.Backpack:GetChildren()
18        local currentGui = gui:Clone()
19        local givingTools = {}
20        local giveButton = currentGui:WaitForChild("MainFrame"):WaitForChild("Give")
21        local replicatedFolder = Instance.new("Folder", game.ReplicatedStorage)
22 
23        if plr.PlayerGui:FindFirstChild("ToolGiver") then
24            plr.PlayerGui:FindFirstChild("ToolGiver"):Destroy()
25        end
26        currentGui.MainFrame.Player.Text = givingPlr.Name
27        currentGui.Parent = plr.PlayerGui
28        for _, tool in pairs (tools) do
29            local currentButton = toolButton:Clone()
30            currentButton.Text = tool.Name
31            currentButton.Parent = currentGui.MainFrame.Tools
32            currentButton.MouseButton1Click:Connect(function()
33                if currentButton.BackgroundTransparency == 0.3 then
34                    table.remove(givingTools, tool)
35                    currentButton.BackgroundTransparency = 0.8
36                else
37                    table.insert(givingTools, tool)
38                    currentButton.BackgroundTransparency = 0.3
39                end
40            end)
41        end
42        giveButton.MouseButton1Click:Connect(function()
43            currentGui:Destroy()
44            for _, tool in pairs (givingTools) do
45                tool.Parent = replicatedFolder
46            end
47            givingEvent:FireServer(replicatedFolder, givingPlr)
48        end)
49    end
50end)
 View all 50 lines...

Are there any errors? cucucu0001 35 — 4y

1 answer

Answered by

cucucu0001 35

4 years ago

Edited 4 years ago

For some reason, there's a problem when passing a player through a Remote Event, you should pass the player's Name property instead

Script:

01local groupId = 6301077
02local ToolGive = Instance.new("RemoteEvent", game.ReplicatedStorage)
03ToolGive.Name = "GivePlayerTools"
04 
05function giveTools(plr, toolFolder, givePlayer)
06    local player = game.Players[givePlayer]
07    print("Fired")
08    if plr:GetRankInGroup(groupId) > -1 then
09        print("Giving tools")
10        local tools = toolFolder:GetChildren()
11        for _, tool in pairs (tools) do
12            tool.Parent = player.Backpack
13            print("Given "..tool.Name)
14        end
15        toolFolder:Destroy()
16    end
17end
18 
19ToolGive.OnServerEvent:Connect(giveTools)

Localscript:

01local gui = script:WaitForChild("ToolGiver")
02local toolButton = script:WaitForChild("Tool")
03local groupId = 6301077
04local plr = game.Players.LocalPlayer
05local mouse = plr:GetMouse()
06local givingEvent = game.ReplicatedStorage:WaitForChild("GivePlayerTools")
07 
08if plr:GetRankInGroup(groupId) > 254 then
09    wait(1)
10    script:Destroy()
11end
12 
13mouse.Button1Down:Connect(function()
14    local target = mouse.Target
15    if mouse.target ~= nil and target.Parent:FindFirstChild("HumanoidRootPart") then
16        local givingPlr = game.Players:GetPlayerFromCharacter(target.Parent)
17        local tools = plr.Backpack:GetChildren()
18        local currentGui = gui:Clone()
19        local givingTools = {}
20        local giveButton = currentGui:WaitForChild("MainFrame"):WaitForChild("Give")
21        local replicatedFolder = Instance.new("Folder", game.ReplicatedStorage)
22 
23        if plr.PlayerGui:FindFirstChild("ToolGiver") then
24            plr.PlayerGui:FindFirstChild("ToolGiver"):Destroy()
25        end
26        currentGui.MainFrame.Player.Text = givingPlr.Name
27        currentGui.Parent = plr.PlayerGui
28        for _, tool in pairs (tools) do
29            local currentButton = toolButton:Clone()
30            currentButton.Text = tool.Name
31            currentButton.Parent = currentGui.MainFrame.Tools
32            currentButton.MouseButton1Click:Connect(function()
33                if currentButton.BackgroundTransparency == 0.3 then
34                    table.remove(givingTools, tool)
35                    currentButton.BackgroundTransparency = 0.8
36                else
37                    table.insert(givingTools, tool)
38                    currentButton.BackgroundTransparency = 0.3
39                end
40            end)
41        end
42        giveButton.MouseButton1Click:Connect(function()
43            currentGui:Destroy()
44            for _, tool in pairs (givingTools) do
45                tool.Parent = replicatedFolder
46            end
47            givingEvent:FireServer(replicatedFolder, givingPlr.Name)
48        end)
49    end
50end)
 View all 50 lines...

Player doesn't recieve item after being given?

1 answer

Answer this question