Scripting Helpers is winding down operations and is now read-only. More info→

attempt to index nil with 'Name' - Giving Tool?

Asked by

kjduck 0

4 years ago

Edited 4 years ago

Hello all,

I am trying to give a player a tool by clicking on him/her.

01local gui = script:WaitForChild("ToolGiver")
02local toolButton = script:WaitForChild("Tool")
03local groupId = 6301077
04local plr = game.Players.LocalPlayer
05local mouse = plr:GetMouse()
06local givingEvent = game.ReplicatedStorage:WaitForChild("GivePlayerTools")
07 
08if plr:GetRankInGroup(groupId) > 240 then
09    wait(1)
10    script:Destroy()
11end
12 
13mouse.Button1Down:Connect(function()
14    local target = mouse.Target
15    if mouse.target ~= nil and target.Parent:FindFirstChild("HumanoidRootPart") then
16        local givingPlayer = game.Players:GetPlayerFromCharacter(target.Parent)
17        local tools = plr.Backpack:GetChildren()
18        local currentGui = gui:Clone()
19        local givingTools = {}
20        local giveButton = currentGui:WaitForChild("MainFrame"):WaitForChild("Give")
21        local replicatedFolder = Instance.new("Folder", game.ReplicatedStorage)
22 
23        if plr.PlayerGui:FindFirstChild("ToolGiver") then
24            plr.PlayerGui:FindFirstChild("ToolGiver"):Destroy()
25        end
26        currentGui.MainFrame.Player.Text = givingPlayer.Name
27        currentGui.Parent = plr.PlayerGui
28        for _, tool in pairs (tools) do
29            local currentButton = toolButton:Clone()
30            currentButton.Text = tool.Name
31            currentButton.Parent = currentGui.MainFrame.Tools
32            currentButton.MouseButton1Click:Connect(function()
33                if currentButton.BackgroundTransparency == 0.3 then
34                    table.remove(givingTools, tool)
35                    currentButton.BackgroundTransparency = 0.8
36                else
37                    table.insert(givingTools, tool)
38                    currentButton.BackgroundTransparency = 0.3
39                end
40            end)
41        end
42        giveButton.MouseButton1Click:Connect(function()
43            currentGui:Destroy()
44            for _, tool in pairs (givingTools) do
45                tool.Parent = replicatedFolder
46            end
47            givingEvent:FireServer(replicatedFolder, givingPlr)
48        end)
49    end
50end)
 View all 50 lines...

LINE 26 IS RETURNING WITH "Players.kjduck.PlayerScripts.ToolGivingLocal:26: attempt to index nil with 'Name' "

Any help would be appreciated :D

Can you put the script on the website i rather not click or download files IcyMizu 122 — 4y

Is this a Script or a LocalScript? cucucu0001 35 — 4y

1 answer

Answered by

cucucu0001 35

4 years ago

You didn't check if the mouse.Hit was a player or not. Updated Code:

01local gui = script:WaitForChild("ToolGiver")
02local toolButton = script:WaitForChild("Tool")
03local groupId = 6301077
04local plr = game.Players.LocalPlayer
05local mouse = plr:GetMouse()
06local givingEvent = game.ReplicatedStorage:WaitForChild("GivePlayerTools")
07 
08if plr:GetRankInGroup(groupId) > 240 then
09  wait(1)
10  script:Destroy()
11end
12 
13mouse.Button1Down:Connect(function()
14local target = mouse.Target
15if mouse.target ~= nil and target.Parent:FindFirstChild("HumanoidRootPart") then
16  local givingPlayer = game.Players:GetPlayerFromCharacter(target.Parent)
17  local tools = plr.Backpack:GetChildren()
18  local currentGui = gui:Clone()
19  local givingTools = {}
20  local giveButton = currentGui:WaitForChild("MainFrame"):WaitForChild("Give")
21  local replicatedFolder = Instance.new("Folder", game.ReplicatedStorage)
22  if (givingPlayer) then
23    if plr.PlayerGui:FindFirstChild("ToolGiver") then
24      plr.PlayerGui:FindFirstChild("ToolGiver"):Destroy()
25    end
26    currentGui.MainFrame.Player.Text = givingPlayer.Name
27    currentGui.Parent = plr.PlayerGui
28    for _, tool in pairs (tools) do
29      local currentButton = toolButton:Clone()
30      currentButton.Text = tool.Name
31      currentButton.Parent = currentGui.MainFrame.Tools
32      currentButton.MouseButton1Click:Connect(function()
33      if currentButton.BackgroundTransparency == 0.3 then
34        table.remove(givingTools, tool)
35        currentButton.BackgroundTransparency = 0.8
36      else
37        table.insert(givingTools, tool)
38        currentButton.BackgroundTransparency = 0.3
39      end
40      end)
41    end
42    giveButton.MouseButton1Click:Connect(function()
43    currentGui:Destroy()
44    for _, tool in pairs (givingTools) do
45      tool.Parent = replicatedFolder
46    end
47    givingEvent:FireServer(replicatedFolder, givingPlr)
48    end)
49  end
50  end)
51end
 View all 51 lines...

attempt to index nil with 'Name' - Giving Tool?

1 answer

Answer this question