Scripting Helpers is winding down operations and is now read-only. More info→

Leaderstats With DataStore Failure?

Asked by

NerfLambdaWarrior120 3

4 years ago

When a value incercrases, it doesn't saves with DataStore, here is the script:

01local DataStoreService = game:GetService("DataStoreService")
02 
03local myDataStore = DataStoreService:GetDataStore("myDataStore")
04 
05 -- Creates a leaderboard that shows player variables
06    local function onPlayerJoin(player)
07        local leaderstats = Instance.new("Folder")
08        leaderstats.Name = "leaderstats"
09        leaderstats.Parent = player
10 
11        local gold = Instance.new("IntValue")
12        gold.Name = "Gold"
13        gold.Value = 0
14        gold.Parent = leaderstats
15 
16        local items= Instance.new("IntValue")
17        items.Name = "Molecules"
18        items.Value = 0
19        items.Parent = leaderstats
20 
21        local spaces = Instance.new("IntValue")
22        spaces.Name = "Spaces"
23        spaces.Value = 2
24        spaces.Parent = leaderstats
25 
26    end
27 
28    -- Run onPlayerJoin when the PlayerAdded event fires
29    game.Players.PlayerAdded:Connect(onPlayerJoin)
30 
31 
32 
33local data      
34local success, errormessage = pcall(function()
35    myDataStore:GetAsync(player.UserId.."-items")
36        myDataStore:GetAsync(player.UserId.."-spaces")
37            myDataStore:GetAsync(player.UserId.."-gold")
38    end)
39 
40game.Players.PlayerRemoving:Connect(function(player)
41 
42    local success, errormessage = pcall(function()
43    data = myDataStore:SetAsync(player.UserId.."-",player.leaderstats.gold.Value)
44 
45    data = myDataStore:SetAsync(player.UserId.."-",player.leaderstats.items.Value)
46 
47    data = myDataStore:SetAsync(player.UserId.."-",player.leaderstats.spaces.Value)
48end)
49 
50if success then
51 
52gold.Value = data
53items.Value = data
54spaces.Value = data
55else
56    print("Unexcepted Error Happened while saving your data! ")
57    warn(errormessage)
58 
59end
60 
61if success then
62print ("playerdatasaved")
63    else
64    print ("playerdatanotsaved")
65    warn(errormessage)
66    end
67end)
 View all 67 lines...

Does any of "print()" actually print something? KrzysiekRoblox 50 — 4y

Yes NerfLambdaWarrior120 3 — 4y

This wont solve your issue but you can set the parent of an instance as the second argument of the instance constructor. E.g: local myPart = Instance.new("Part", workspace) SuchASaltyLemon 35 — 4y

So, if yes, which one prints something? KrzysiekRoblox 50 — 4y

View all comments (3 more)

lemme check NerfLambdaWarrior120 3 — 4y

it doesn' t prints something (i confused with the script of the BuyButton that i putted in the game) NerfLambdaWarrior120 3 — 4y

here you have the link of the game (wich is uncopylocked and it it's just a test for the script for the original one) LINK: https://www.roblox.com/games/5023928146/Untitled-Game NerfLambdaWarrior120 3 — 4y

1 answer

Answered by

KrzysiekRoblox 50

4 years ago

First things first, "player" in lines 35-37 is not defined anywhere. Script doesn't understand what 'player' is.

Second, "gold", "items" and "spaces" in lines 52-54 are also not defined. Even if you create a variable in function, it doesn't work outside it.

I think your problem is, that you don't understand how to use scopes. Here's a Roblox tutorial about it: https://developer.roblox.com/en-us/articles/Scope

Also, there's a nice Roblox tutorial that explains how to correctly save player's data on exit: https://developer.roblox.com/en-us/articles/Saving-Player-Data

Making it the way you've done it is a bad practice. After player leaves the game script can't access "leaderstats" object, because it's already gone. You should do this the way as it's shown in the second link :)

And also, when you test DataStore, I recommend doing it in actual game, not in Roblox Studio. DataStore in Roblox Studio doesn't always work with game.Players.PlayerRemoving.

Hope I helped :)

Leaderstats With DataStore Failure?

1 answer

Answer this question