FindFirstChild() results with an error but no bug?
I have a game that uses FindFirstChild() to give the player money when they touch a brick. It results with an error but still works. My code is something like this (not exact cause I am on mobile and doing it off my head):
01 | local denounce = 0 |
02 |
03 | script.Parent.Touched:connect(function(player) |
04 | If debounce == 0 then |
05 | debounce = 1 |
06 | local plr = player:GetPlayerFromCharacter() |
07 | local stats = plr:FindFirstChild('leaderstats') |
08 | local value = stats:FindFirstChild('Money') |
09 | value.Value = value.Value + 100 |
10 | wait(5) |
11 | debounce = 0 |
12 | end |
Thanks, JailBreaker_13
0
0
1 answer
Hello. There are quite some problems and recommendations I will give you with your script.
Problems:
You did not use the argument of
GetPlayerFromCharacter().You forgot an end.
You did not check if the part hit was a player.
Solutions:
Make the argument of
GetPlayerFromCharacter()"hit.Parent".Add an end.
Make an if statement checking if the player is what touched the part.
Recommendations:
Use
connectwith an uppercase "C" asconnectis deprecated. It is never a good idea to use deprecated functions.Rename the parameter for the touched event to "hit" as it makes more sense.
You don't need to use
FindFirstChild()since all players will have a leaderstats and money value.Use a
trueandfalsebased debounce instead of a number based one.
Fixed Script:
01 | local debounce = false |
02 |
03 | script.Parent.Touched:Connect(function(hit) |
04 | local plr = player:GetPlayerFromCharacter(hit.Parent) |
05 |
06 | if not debounce and plr then |
07 | debounce = true |
08 | local stats = plr.leaderstats |
09 | local value = stats.Money |
10 | value.Value = value.Value + 100 |
11 | wait(5) |
12 | debounce = false |
13 | end |
14 | end |
0
0
0