Scripting Helpers is winding down operations and is now read-only. More info→

Datastore Money Value is not saving correctly, any help?

Asked by

4 years ago

I have this modified script mostly inspired by Youtube and it doesn't fully work. The Kills value saves perfectly, unlike the Money. What happens is that after a few hours to days, most of the total Money earned will reset or decrease about 80-90%. Being a nearly essential part of the game, I believe resetting the value will just erase everybody's total progress and possibly encounter the problem again. This is a trend in all players that exceed 1000 in cash. I currently have more than 2000 kills, and I should have three times the amount in cash, however my data just erased several times and I currently have about 450 Money.

As I got this tutorial on how to make it from YT, I am not sure how to troubleshoot or fix this.

Note: Money is gained from killing players and NPCs, and is used on things to buy. Kills are just collected.

01local datastore = game:GetService("DataStoreService")
02local ds1 = datastore:GetDataStore("MoneySaveSystem")
03local ds2 = datastore:GetDataStore("KillsSaveSystem")
04 
05game.Players.PlayerAdded:Connect(function(plr)
06    local folder = Instance.new("Folder", plr)
07    folder.Name = "leaderstats"
08    local money = Instance.new("IntValue", folder)
09    money.Name = "Money"
10    local kills = Instance.new("IntValue", folder)
11    kills.Name = "Kills"
12 
13    money.Value = ds1:GetAsync(plr.UserId) or 0
14    ds1:SetAsync(plr.UserId, money.Value)
15 
16    kills.Value = ds2:GetAsync(plr.UserId) or 0
17    ds2:SetAsync(plr.UserId, kills.Value)
18 
19    money.Changed:connect(function()
20        ds1:SetAsync(plr.UserId, money.Value)
21    end)
22 
23    kills.Changed:connect(function()
24        ds2:SetAsync(plr.UserId, kills.Value)
25    end)
26end)
27 
28game.Players.PlayerRemoving:Connect(function(player)
29    local success, errormessage = pcall(function()
30        ds1:SetAsync(player.UserId.."-money",player.leaderstats.Money.Value)
31    end)
32 
33    if success then
34        print ("Player Data successfully saved.")
35    else
36        print ("Error in saving Player Data.")
37        warn (errormessage)
38    end
39end)
 View all 39 lines...

1 answer

Answered by

ParticularlyPenguin 71

4 years ago

Quite simple fix, you just mixed up the keys.

01local datastore = game:GetService("DataStoreService")
02local ds1 = datastore:GetDataStore("MoneySaveSystem")
03local ds2 = datastore:GetDataStore("KillsSaveSystem")
04 
05game.Players.PlayerAdded:Connect(function(plr)
06    local folder = Instance.new("Folder", plr)
07    folder.Name = "leaderstats"
08    local money = Instance.new("IntValue", folder)
09    money.Name = "Money"
10    local kills = Instance.new("IntValue", folder)
11    kills.Name = "Kills"
12 
13    money.Value = ds1:GetAsync(plr.UserId) or 0
14    ds1:SetAsync(plr.UserId, money.Value)
15 
16    kills.Value = ds2:GetAsync(plr.UserId) or 0
17    ds2:SetAsync(plr.UserId, kills.Value)
18 
19    money.Changed:connect(function()
20        ds1:SetAsync(plr.UserId, money.Value)
21    end)
22 
23    kills.Changed:connect(function()
24        ds2:SetAsync(plr.UserId, kills.Value)
25    end)
26end)
27 
28game.Players.PlayerRemoving:Connect(function(player)
29    local success, errormessage = pcall(function()
30        ds1:SetAsync(player.UserId, player.leaderstats.Money.Value)
31    end)
32 
33    if success then
34        print ("Player Data successfully saved.")
35    else
36        print ("Error in saving Player Data.")
37        warn (errormessage)
38    end
39end)
 View all 39 lines...

For the player removing, you had it as a different key than the player added.

If this still causes you problems then I don't know how to fix them, as I've never seen a datastore script formatted like this. ParticularlyPenguin 71 — 4y

Thank you, I was going into this semi-blind and hope it is simply my mistake. I will let you know if this works. Bgonzalezseeya11 27 — 4y

The fix did not solve the problem, but it did reduce how much money as lost. Thanks for your help. Bgonzalezseeya11 27 — 4y

Datastore Money Value is not saving correctly, any help?

1 answer

Answer this question