Scripting Helpers is winding down operations and is now read-only. More info→

Leaderboard not updating/saving values?

Asked by

snoppyploptart 59

5 years ago

I am trying to make a script to save a value called "Reputation" and update the datastores when a player gets the increase (like at the end of a round) or when they're leaving. I used a block to test this out by giving me 10 Rep every time I touch it and it worked at first but the value wouldn't save. All the code 'checkpoints,' if you will, gave me success messages but the values still don't save. I have tried rewriting it several times and I have searched for examples to go off of and I cannot seem to get it to work. I was trying to get it to index a player with a value of 1 if they didn't exist but this is proving to be rather tricky. I even watch the value of the IntValue stay at 0 even though the code shows it at 10 when using a breakpoint. I think I might just not be finding the correct value for reputation but I figured I could still submit it here to see if I could save some time. Below is my code for the leaderboard:

01--Datastore--
02local Datastore = game:GetService("DataStoreService") --gets service
03local GameStatStorage = Datastore:GetDataStore("gamestats") --creates a link to use for accessing the datastore
04 
05 
06game.Players.PlayerAdded:Connect(function(plr) --when a player joins
07    local folder = Instance.new("Folder")  --Makes folder for stats
08    folder.Parent = plr --places it 
09    folder.Name = "leaderstats" --names it
10    local reputation = Instance.new("IntValue") -- makes a place to store the value of the players reputaion
11    reputation.Parent = folder --places the value container
12    reputation.Name = "Reputation"
13    local success, err = pcall(function() --wraps in pcall
14        GameStatStorage:GetAsync(plr.UserId.."-Reputation") --gets the players data
15    end)
16    if success then --if good then 
17        print "Successfully Loaded" --Success message
18        plr.leaderstats.Reputation.Value = success --sets visible value to match
19    else --or if player doesnt have data to pull
20        plr.leaderstats.Reputation.Value = 1 -- then give them a value of zero to display
21        GameStatStorage:SetAsync(plr.UserId, 1) --submit the number to the datastore server
22        print "Player Data not found. Err201"
23        warn "Err201 - Value created and set to 1"
24    end
25 
26end)
27 
28game.Players.PlayerRemoving:Connect(function(plr) --when player is leaving
29 
30    local function valueOfRep()
31        return plr.leaderstats.Reputation.Value
32    end
33 
34    local success, err = pcall(function() --wrap in pcall
35        GameStatStorage:UpdateAsync(plr.UserId.."-Reputation", valueOfRep) --saves value the person has
36    end)
37    if success then
38        print "Save to leave Successful"
39    else
40            print("Error in saving to leave")
41            warn(err)
42    end
43end)
 View all 43 lines...

1 answer

Answered by

youtubemasterWOW 2741

5 years ago

Edited 5 years ago

Hello, snoppyploptart. You wrote reputation.Value = success. This would not work because success is a boolean and the value is an integer. Instead, add a variable and set it to the GameStatStorage:GetAsync() function as it returns the data, in this case, a number. Also, you should use :SetAsync() instead of :UpdateAsync() and it is recommended to set the instance's name first and then parent it while using Instance.new().. Try this:

01--Datastore--
02local Datastore = game:GetService("DataStoreService") --gets service
03local GameStatStorage = Datastore:GetDataStore("gamestats") --creates a link to use for accessing the datastore
04 
05 
06game.Players.PlayerAdded:Connect(function(plr) --when a player joins
07    local folder = Instance.new("Folder")  --Makes folder for stats
08    folder.Name = "leaderstats" --names it
09    folder.Parent = plr --places it 
10 
11    local reputation = Instance.new("IntValue") -- makes a place to store the value of the players reputaion
12    reputation.Name = "Reputation"
13    reputation.Parent = folder --places the value container
14 
15 
16    local data
17 
18    local success, err = pcall(function() --wraps in pcall
19        data = GameStatStorage:GetAsync(plr.UserId.."-Reputation") --gets the players data
20    end)
21    if success then --if good then 
22        print "Successfully Loaded" --Success message
23       reputation.Value = data
24    else --or if player doesnt have data to pull
25        plr.leaderstats.Reputation.Value = 1 -- then give them a value of zero to display
26    warn(err)
27    end
28 
29end)
30 
31game.Players.PlayerRemoving:Connect(function(plr) --when player is leaving
32 
33    local function valueOfRep()
34        return plr.leaderstats.Reputation.Value
35    end
36 
37    local success, err = pcall(function() --wrap in pcall
38        GameStatStorage:SetAsync(plr.UserId.."-Reputation", valueOfRep) --saves value the person has
39    end)
40    if success then
41        print "Save to leave Successful"
42    else
43            print("Error in saving to leave")
44            warn(err)
45    end
46end)
 View all 46 lines...

If it doesn't work, make sure API Services are enabled. Note that DataStores don't work in studio. If this helped you, make sure to accept the answer!

I tried this and changed line 23 to data + 10 so that if I existed in the store somehow as 0 it would give me 10 more than the last time I joined. This was not the case. Instead, every time I join I have 10 now. This is for sure a step forward though so I greatly appreciate the feedback! snoppyploptart 59 — 5y

No problem. youtubemasterWOW 2741 — 5y

I got it to work by making the value of the fuction in line33 into a variable because in line38 it was a function in the parameters so by making it a variable I assume it parsed it and now it's saving values. Thank you so much for the help again! Couldn't have done it without you snoppyploptart 59 — 5y

Leaderboard not updating/saving values?

1 answer

Answer this question