Scripting Helpers is winding down operations and is now read-only. More info→

How would i fix this DataStore script? First DataStore.

Asked by

4 years ago

So i'm making a game that requires saving but i cant find out how to make a working DataStore, I got this script from Alvinblox on Youtube but it still doesn't work.

01local DataStoreService = game:GetService("DataStoreService")
02 
03local MyDataStore = DataStoreService:GetDataStore('MyDataStore')
04 
05 
06 
07 
08 
09game.Players.PlayerAdded:Connect(function(player)
10    local stats = Instance.new("Folder")
11    stats.Name = 'leaderstats'
12    stats.Parent = player
13 
14    local cash = Instance.new("NumberValue")
15    cash.Name = 'Cash'
16    cash.Parent = stats
17 
18 
19    local data
20    local success, errormessage = pcall(function()
21        MyDataStore:GetAsync(player.UserId.."-cash")
22    end)
23 
24    if success then
25        cash.Value = data
26    else
27            print('error')
28            print(errormessage)
29    end
30 
31 
32 
33end)
34 
35game.Players.PlayerRemoving:Connect(function(player)
36 
37 
38    local success, errormessage = pcall(function()
39    MyDataStore:SetAsync(player.UserId.."-cash",player.leaderstats.Cash.Value)
40    end)
41    if success then
42        print('Saved')
43    else
44            print("Error")
45    end
46 
47end)
 View all 47 lines...

What am i doing wrong?

Note - This is a server script in ServerScriptService

Thanks for reading.

What error does it show? AM910sk 22 — 4y

No errors it just doesn't work. EllaTheFloofyFox 106 — 4y

DataStores needs to be enabled on game settings to work on studio. Do it works on the real game? Leamir 3138 — 4y

1 answer

Answered by

youtubemasterWOW 2741

4 years ago

I think it doesn't work because you didn't add an if statement asking if there was data. It wouldn't work because the player wouldn't have any data, so their cash would be equal to nil. Try this:

01local DataStoreService = game:GetService("DataStoreService")
02 
03local MyDataStore = DataStoreService:GetDataStore('MyDataStore')
04 
05 
06 
07 
08 
09game.Players.PlayerAdded:Connect(function(player)
10    local stats = Instance.new("Folder")
11    stats.Name = 'leaderstats'
12    stats.Parent = player
13 
14    local cash = Instance.new("NumberValue")
15    cash.Name = 'Cash'
16    cash.Parent = stats
17 
18 
19    local data
20    local success, errormessage = pcall(function()
21        MyDataStore:GetAsync(player.UserId.."-cash")
22    end)
23 
24    if success then
25    if data then
26            cash.Value = data
27    end
28    else
29            print('error')
30            warn(errormessage)
31    end
32 
33 
34 
35end)
36 
37game.Players.PlayerRemoving:Connect(function(player)
38 
39 
40    local success, errormessage = pcall(function()
41    MyDataStore:SetAsync(player.UserId.."-cash",player.leaderstats.Cash.Value)
42    end)
43    if success then
44        print('Saved')
45    else
46            print("Error")
47        warn(errormessage)
48    end
49 
50end)
 View all 50 lines...

If that doesn't work, then it means you haven't enabled API Services in your game.

How would i fix this DataStore script? First DataStore.

1 answer

Answer this question