Scripting Helpers is winding down operations and is now read-only. More info→

How to make this UserInput shorter?

Asked by

NinjoOnline 1146

10 years ago

01local UserInput = game:GetService('UserInputService')
02 
03UserInput.InputBegan:connect(function(input)
04    if input.KeyCode == Enum.KeyCode.One then
05        script.Parent.Inventory.MainFrame.InvSpace.Inv1.BackgroundTransparency = 0.5
06        script.Parent.Inventory.MainFrame.InvSpace.Inv2.BackgroundTransparency = 0.7
07        script.Parent.Inventory.MainFrame.InvSpace.Inv3.BackgroundTransparency = 0.7   
08        script.Parent.Inventory.MainFrame.InvSpace.Inv4.BackgroundTransparency = 0.7
09        script.Parent.Inventory.MainFrame.InvSpace.Inv5.BackgroundTransparency = 0.7
10    elseif input.KeyCode == Enum.KeyCode.Two then
11        script.Parent.Inventory.MainFrame.InvSpace.Inv2.BackgroundTransparency = 0.5
12        script.Parent.Inventory.MainFrame.InvSpace.Inv1.BackgroundTransparency = 0.7
13        script.Parent.Inventory.MainFrame.InvSpace.Inv3.BackgroundTransparency = 0.7   
14        script.Parent.Inventory.MainFrame.InvSpace.Inv4.BackgroundTransparency = 0.7
15        script.Parent.Inventory.MainFrame.InvSpace.Inv5.BackgroundTransparency = 0.7
16    elseif input.KeyCode == Enum.KeyCode.Three then
17        script.Parent.Inventory.MainFrame.InvSpace.Inv3.BackgroundTransparency = 0.5
18        script.Parent.Inventory.MainFrame.InvSpace.Inv1.BackgroundTransparency = 0.7
19        script.Parent.Inventory.MainFrame.InvSpace.Inv2.BackgroundTransparency = 0.7   
20        script.Parent.Inventory.MainFrame.InvSpace.Inv4.BackgroundTransparency = 0.7
21        script.Parent.Inventory.MainFrame.InvSpace.Inv5.BackgroundTransparency = 0.7
22    elseif input.KeyCode == Enum.KeyCode.Four then
23        script.Parent.Inventory.MainFrame.InvSpace.Inv4.BackgroundTransparency = 0.5
24        script.Parent.Inventory.MainFrame.InvSpace.Inv1.BackgroundTransparency = 0.7
25        script.Parent.Inventory.MainFrame.InvSpace.Inv2.BackgroundTransparency = 0.7   
26        script.Parent.Inventory.MainFrame.InvSpace.Inv3.BackgroundTransparency = 0.7
27        script.Parent.Inventory.MainFrame.InvSpace.Inv5.BackgroundTransparency = 0.7   
28    elseif input.KeyCode == Enum.KeyCode.Five then
29        script.Parent.Inventory.MainFrame.InvSpace.Inv5.BackgroundTransparency = 0.5
30        script.Parent.Inventory.MainFrame.InvSpace.Inv1.BackgroundTransparency = 0.7
31        script.Parent.Inventory.MainFrame.InvSpace.Inv2.BackgroundTransparency = 0.7   
32        script.Parent.Inventory.MainFrame.InvSpace.Inv3.BackgroundTransparency = 0.7
33        script.Parent.Inventory.MainFrame.InvSpace.Inv4.BackgroundTransparency = 0.7
34    end
35end)
 View all 35 lines...

How could I possibly make this shorten, but not change what the outcome is?

2 answers

Answered by

Nifer2 174

10 years ago

01local UserInput = game:GetService('UserInputService')
02local Inv1 = script.Parent.Inventory.MainFrame.InvSpace.Inv1
03local Inv2 = script.Parent.Inventory.MainFrame.InvSpace.Inv2
04local Inv3 = script.Parent.Inventory.MainFrame.InvSpace.Inv3
05local Inv4 = script.Parent.Inventory.MainFrame.InvSpace.Inv4
06local Inv5 = script.Parent.Inventory.MainFrame.InvSpace.Inv5
07 
08UserInput.InputBegan:connect(function(input)
09    if input.KeyCode == Enum.KeyCode.One then
10        Inv1.BackgroundTransparency = 0.5
11        Inv2.BackgroundTransparency = 0.7
12        Inv3.BackgroundTransparency = 0.7   
13        Inv4.BackgroundTransparency = 0.7
14        Inv5.BackgroundTransparency = 0.7
15    elseif input.KeyCode == Enum.KeyCode.Two then
16        Inv2.BackgroundTransparency = 0.5
17        Inv1.BackgroundTransparency = 0.7
18        Inv3.BackgroundTransparency = 0.7   
19        Inv4.BackgroundTransparency = 0.7
20        Inv5.BackgroundTransparency = 0.7
21    elseif input.KeyCode == Enum.KeyCode.Three then
22        Inv3.BackgroundTransparency = 0.5
23        Inv1.BackgroundTransparency = 0.7
24        Inv2.BackgroundTransparency = 0.7   
25        Inv4.BackgroundTransparency = 0.7
26        Inv5.BackgroundTransparency = 0.7
27    elseif input.KeyCode == Enum.KeyCode.Four then
28       Inv4.BackgroundTransparency = 0.5
29        Inv1.BackgroundTransparency = 0.7
30        Inv2.BackgroundTransparency = 0.7   
31        Inv3.BackgroundTransparency = 0.7
32       Inv5.BackgroundTransparency = 0.7   
33    elseif input.KeyCode == Enum.KeyCode.Five then
34        Inv5.BackgroundTransparency = 0.5
35        Inv1.BackgroundTransparency = 0.7
36        Inv2.BackgroundTransparency = 0.7   
37        Inv3.BackgroundTransparency = 0.7
38        Inv4.BackgroundTransparency = 0.7
39    end
40end)
 View all 40 lines...

I just created variables. You should try using variables more often so you can type less. If less lines was what you wanted then I really can't help you with that. :/

yeah I would of liked less lines, but it's ok. I shall use the variables, don't tend to use variables much. NinjoOnline 1146 — 10y

Okay! Nifer2 174 — 10y

Answered by

TurboFusion 1821

10 years ago

I pretty much cut the original script in half by getting rid of the repetition and replacing it with a function

01local UserInput = game:GetService('UserInputService')
02local Inventory = script.Parent.Inventory.MainFrame.InvSpace
03 
04function EditInv(Num)
05    for i = 1,5 do --For loop that runs from 1 to 5
06        local Inv = Inventory["Inv"..i] --Finds the "Inv" with the number "i" after it
07        if i == Num then --If the located Inv is the Inv that you want to change...
08            Inv.BackgroundTransparency = 0.5
09        else --If it's not...
10            Inv.BackgroundTransparency = 0.7
11        end
12    end
13end
14 
15UserInput.InputBegan:connect(function(input)
16    if input.KeyCode == Enum.KeyCode.One then
17        EditInv(1)
18    elseif input.KeyCode == Enum.KeyCode.Two then
19        EditInv(2)
20    elseif input.KeyCode == Enum.KeyCode.Three then
21        EditInv(3)
22    elseif input.KeyCode == Enum.KeyCode.Four then
23        EditInv(4)
24    elseif input.KeyCode == Enum.KeyCode.Five then
25        EditInv(5)
26    end
27end)
 View all 27 lines...

How to make this UserInput shorter?

2 answers

Answer this question