Scripting Helpers is winding down operations and is now read-only. More info→
Ad
Log in to vote
0

I am trying to make a global leaderboard using datastores but its not working! HELP!?

Asked by 4 years ago
Edited 4 years ago

This is not my script credit to ThatTimothy https://devforum.roblox.com/t/how-to-make-a-simple-global-leaderboard/256754

So there is a problem where it isnt showing my leaderstats on the board. The datastore part works just anything below that doesnt. I want this to show how many Wins a player has, but before it was showing Joins so how do I swap it out?

local sg = script.Parent --Surface GUI
local sample = script:WaitForChild("Sample") --Our Sample frame
local sf = sg:WaitForChild("ScrollingFrame") --The scrolling frame
local ui = sf:WaitForChild("UI") --The UI list layout

local datastore = game:GetService("DataStoreService")
local ds1 = datastore:GetDataStore("WinsSaveSystem")

game.Players.PlayerAdded:connect(function(plr)
local folder = Instance.new("Folder", plr)
folder.Name = "leaderstats"
local wins = Instance.new("IntValue", folder)
wins.Name = "Wins"

wins.Value = ds1:GetAsync(plr.UserId) or 0
ds1:SetAsync(plr.UserId, wins.Value)

wins.Changed:connect(function()
  ds1:SetAsync(plr.UserId, wins.Value)
 end)
end)  
wait(10)
while true do -- this is the part where nothing works 
    for i,plr in pairs(game.Players:GetChildren()) do--Loop through players
        if plr.UserId>0 then--Prevent error
                pcall(function()
                --Wrap in a pcall so if Roblox is down, it won't error and break.
                    ds1:UpdateAsync(plr.UserId,function(winsVal)
                        --Set new value
                    end)
                end)
            end
        end   
    local smallestFirst = false--false = 2 before 1, true = 1 before 2
    local numberToShow = 100--Any number between 1-100, how many will be shown
    local minValue = 1--Any numbers lower than this will be excluded
    local maxValue = 10e30--(10^30), any numbers higher than this will be excluded
    local pages = ds1:GetSortedAsync(smallestFirst, numberToShow, minValue, maxValue)
    --Get data
    local top = pages:GetCurrentPage()--Get the first page
    local data = {}--Store new data
    for a,b in ipairs(top) do--Loop through data
        local userid = b.key--User id
        local points = b.value--Points
        local username = "[Failed To Load]"--If it fails, we let them know
        local s,e = pcall(function()
         username = game.Players:GetNameFromUserIdAsync(userid)--Get username
        end)
        if not s then--Something went wrong
           warn("Error getting name for "..userid..". Error: "..e)
        end
        local image = game.Players:GetUserThumbnailAsync(userid, Enum.ThumbnailType.HeadShot, Enum.ThumbnailSize.Size150x150)
        --Make a image of them
        table.insert(data,{username,points,image})--Put new data in new table
    end
    ui.Parent = script
    sf:ClearAllChildren()--Remove old frames
    ui.Parent = sf
    for number,d in pairs(data) do--Loop through our new data
        local name = d[1]
        local val = d[2]
        local image = d[3]
        local color = Color3.new(1,1,1)--Default color
        if number == 1 then
            color = Color3.new(1,1,0)--1st place color
        elseif number == 2 then
            color = Color3.new(0.9,0.9,0.9)--2nd place color
        elseif number == 3 then
            color = Color3.fromRGB(166, 112, 0)--3rd place color
        end
        local new = sample:Clone()--Make a clone of the sample frame
        new.Name = name--Set name for better recognition and debugging
        new.LayoutOrder = number--UIListLayout uses this to sort in the correct order
        new.Image.Image = image--Set the image
        new.Image.Place.Text = number--Set the place
        new.Image.Place.TextColor3 = color--Set the place color (Gold = 1st)
        new.PName.Text = name--Set the username
        new.Value.Text = val--Set the amount of points
        new.Value.TextColor3 = color--Set the place color (Gold = 1st)
        new.PName.TextColor3 = color--Set the place color (Gold = 1st)
        new.Parent = sf--Parent to scrolling frame
    end
    wait()
    sf.CanvasSize = UDim2.new(0,0,0,ui.AbsoluteContentSize.Y)
    --Give enough room for the frames to sit in
    wait(120)
end
0
First, double-check the script to his and see if you can fix it yourself. If not, I would highly reccomend dissecting the script and seeing if you can spot the error. NickIsANuke 217 — 4y
0
I have been trying to fix it for the last hour but I get nothing. And I got an error that says GetSortedAsync is not a valid member of GlobalDataStore Nistrict 44 — 4y

Answer this question