✓ ANSWER ACCEPTED

(Player Name) is not a valid member of Players. Help anyone?

Asked Jan 6, 2020961 views2 answers

Hi guys, this is my first ever question on here. So I'm trying to make a Camping-like game it is called Truth or Dare. All the other scripts work except for this one. The script is supposed to make a GUI pop up once a player touches a specific part. But when I touch the part, I look at the output and an error has popped up saying, "ally_playz336 is not a valid member of Players." So here is the script:

local GUI = script.Parent.ScreenGui -- You might want to change this to whatever your GUI is.
script.Parent.PlayerTouched:connect(function(hit)
	if hit.Parent and game.Players:FindFirstChild(hit.Parent.Name) then
		local plr = game.Players(hit.Parent.Name)
		if plr:FindFirstChild("PlayerGui") and not plr.PlayerGui:FindFirstChild(GUI.Name) then
			GUI.Clone().Parent = plr.PlayerGui
		end
	end
end)

I don't know if there is anything wrong with it, because it looks fine to me. The only problem is that it won't work. Help is greatly appreciated ????

AnonymousJan 6, 2020

2 answers

✓ Accepted answer

hit.Parent.Name is a part of hit.Parent. not a child (I think, correct me if im wrong), so an easier way to get the person touched would be to used GetPlayerFromCharacter.

Instead of using:

if hit.Parent and game.Players:FindFirstChild(hit.Parent.Name) then
        local plr = game.Players(hit.Parent.Name)

Try:

if hit.Parent  then
local plr = hit.Parent:GetPlayerFromCharacter

So the script would be:

local GUI = script.Parent.ScreenGui

script.Parent.PlayerTouched:connect(function(hit)
   if hit.Parent and game.Players:FindFirstChild(hit.Parent.Name) then
local plr = hit.Parent:GetPlayerFromCharacter
        if plr:FindFirstChild("PlayerGui") then
            GUI.Clone().Parent = plr.PlayerGui
        end
    end
end)

I hope that works!

Also I don't know why you need:

and not plr.PlayerGui:FindFirstChild(GUI.Name) then

But again, correct me if theres a reason. ;D

AnonymousJan 6, 2020Permalink

8 comments

@fighterkirbyzx It still doesn't work. Another error has popped up in my output saying, "16:55:45.783 - Workspace.GUIGiver.Script:6: Expected '(', '{' or , got 'if'" I don't think it works :(

AnonymousJan 6, 2020#

what line was the error?

AnonymousJan 6, 2020#

@manith513 The error had a 6 in it, so I think it may be on line 6.

AnonymousJan 6, 2020#

wiat

AnonymousJan 6, 2020#

what? :|

AnonymousJan 6, 2020#

I know the issue

AnonymousJan 6, 2020#

use game:GetService:("Players"):GetPlayerFromCharacter(hit.Parent) instead

AnonymousJan 6, 2020#

i forgot the () ;-;

AnonymousJan 6, 2020#

NOW AFTER EDITS OFFICIALLY WORKING!

Sorry I glitched from my other comment can you tell me if this works I think you should try the script with this

local GUI = script.Parent.ScreenGui

script.Parent.Touched:Connect(function(hit)
  local plr = game.Players:GetPlayerFromCharacter(hit.Parent)
	if plr then
        	if plr:FindFirstChild("PlayerGui") then
            		GUI.Clone().Parent = plr.PlayerGui.ScreenGui
		end
        end
 
end)

always remember to add the next child screen gui after player gui btw

AnonymousJan 6, 2020Edited Jan 7, 2020Permalink

14 comments

Sorry I forgot about the parenthesis try this now

AnonymousJan 6, 2020#

GetPlayerFromCharacter is a method of game.Players. The line should read "local player = game.Players:GetPlayerFromCharacter(hit.Parent)". An then you'll need to check if player exists. See the bottom of this page https://developer.roblox.com/en-us/api-reference/function/Players/GetPlayerFromCharacter

AnonymousJan 6, 2020#

@vector thanks I forgot about that

AnonymousJan 6, 2020#

@manith I dont think this one works either. PlayerTouched is not a valid member of Part... :c

AnonymousJan 6, 2020#

also why dont you use script.Parent.Touched:Connect? I've never even used PlayerTouched

AnonymousJan 6, 2020#

@ally lemme edit the script real quick

AnonymousJan 6, 2020#

@ally finished

AnonymousJan 6, 2020#

@ally I just made some new edits that i tested and it should work it works on my behalf

AnonymousJan 7, 2020#

@ally for some reason the ends are misplaced to move the end on line 8 under the if plr find first child state ment on the same line and move the end on line 9 to the if plr is a statement on the same line

AnonymousJan 7, 2020#

Line 5 should read "if plr then". It will either exist or not. You just need to check if it exists, and if it does it can only be a player as we got it from GetPlayerFromCharacter, which returns a player or nil.

AnonymousJan 7, 2020#

right thank you

AnonymousJan 7, 2020#

vector3_zero do you mind looking at one of my posts about an arrow direction please? you look like a pretty good scripter do you mind helping me please?

AnonymousJan 7, 2020#

vector3_zero wait is there a difference between hit.Parent:GetPlayerFromCharacter() and game.Players:GetPlayerFromCharacter(hit.Parent)?

AnonymousJan 11, 2020#

This discussion is preserved as it was. New answers, comments, and votes are closed.