✓ ANSWER ACCEPTED

"If's and and's" Help please? [SOLVED]

Asked Jul 19, 2014225 views3 answers

Hello, please may I have some help with this script please? I have no idea why it isn't working...

Please help me correct this please! Thanks.

BuzzerOne=game.Workspace.Buzzers.BuzzerOne
BuzzerTwo=game.Workspace.Buzzers.BuzzerTwo
BuzzerThree=game.Workspace.Buzzers.BuzzerThree
Intro=game.Workspace.Intro

function onClick()
	if BuzzerOne.BrickColor.Red() and BuzzerTwo.BrickColor.Red() and BuzzerThree.BrickColor.Red() then
		Intro:Play()
	end
end


script.Parent.ClickDetector.MouseClick:connect(onClick)

16:53:37.142 - BrickColor is not a valid member of Model 16:53:37.143 - Script 'Workspace.Part.Script', Line 7

AnonymousJul 19, 2014Edited Jul 19, 2014

3 comments

Please show us what is inside BuzzerOne, BuzzerTwo and BuzzerThree.

AnonymousJul 19, 2014#

Nothing. Just parts

AnonymousJul 19, 2014#

http://oi62.tinypic.com/2445tmh.jpg Here

AnonymousJul 19, 2014#

3 answers

✓ Accepted answer

Correction

BuzzerOne=game.Workspace.Buzzers.BuzzerOne
BuzzerTwo=game.Workspace.Buzzers.BuzzerTwo
BuzzerThree=game.Workspace.Buzzers.BuzzerThree
Buzzers = {BuzzerOne,BuzzerTwo,BuzzerThree}
Intro=game.Workspace.Intro

function onClick()
	local isvalid = true
	for _,v in pairs(Buzzers) do
		for _,w in pairs(v:GetChildren()) do
			if w.BrickColor ~= BrickColor.Red() then
				isvalid = false
			end
		end
	end
    if isvalid then
        Intro:Play()
    end
end

script.Parent.ClickDetector.MouseClick:connect(onClick)

Explanation

There were parts inside the models. Those are what you have to test the BrickColor on, not the model itself as it has no BrickColor on it.

AnonymousJul 19, 2014Edited Jul 19, 2014Permalink

1 comment

Worked perfectly thanks! :)

AnonymousJul 19, 2014#

As the error says,

BuzzerOne (or ..Two or ..Three, I don't know which; but probably all of them) is a Model. Models don't have BrickColor properties, which is your error. Make BuzzerOne refer to a part rather than a model.

If it were a part, your code still wouldn't work. You have to compare the values, not just call .Red() on them. Comparison for equality is done with the == operator (read "is equal to"). It is unrelated to the assignment construct =.

if BuzzerOne.BrickColor == BrickColor.Red() and BuzzerTwo.BrickColor == BrickColor.Red() and BuzzerThree.BrickColor == BrickColor.Red() then

AnonymousJul 19, 2014Edited Jul 19, 2014Permalink

3 comments

It is still giving me a error ;( 17:04:58.560 - BrickColor is not a valid member of Model 17:04:58.561 - Script 'Workspace.Part.Script', Line 7

AnonymousJul 19, 2014#

You didn't change it then. The accepted answer works because it is fixing it for you by using a much more complicated solution.

AnonymousJul 19, 2014#

Ahh. Okay. Anyway you helped me too :) Because I needed this for another thingy mabob haha.Thanks :)

AnonymousJul 19, 2014#

This is just to test with to show that it works this script works with a normal brick, I used name but you could use other. hope this helps

while true do
	if script.Parent.BrickColor.Name == "Bright red" then
		print("ok")
	end
	wait(5)
end

AnonymousJul 19, 2014Permalink

This discussion is preserved as it was. New answers, comments, and votes are closed.