✓ ANSWER ACCEPTED

Can a Function be Called Again Before Completion?

Asked Jun 18, 2019244 views2 answers

I am trying to make a gate rise, with each part only rising a certain amount. I want the function (raiseGate) to act on all parts of the gate at once rather than doing each piece one at a time. Is there a way to do this? Thanks so much!

function raiseGate(piece)
	local amount = piece.Order.Value
	for i = 0, amount do
		piece.CFrame = piece.CFrame + Vector3.new(0, 1.9629, 0)
		wait(.2)
	end
end

function onClicked()
	local gates = game.workspace.GateModel:GetChildren()
	for i, child in ipairs(gates) do
		raiseGate(child)
		wait(.1)
	end
end
script.Parent.ClickDetector.MouseClick:connect(onClicked)

AnonymousJun 18, 2019

2 answers

✓ Accepted answer

What I would do in this situation is use spawn.

You could use coroutines but I find spawns to be easier. Unlike coroutines, spawn does not return a reference.

Using spawn will create a new thread that will allow us to skip over the wait inside the raiseGate function.

So lets utilize it here

function raiseGate(piece)
    local amount = piece.Order.Value
    for i = 0, amount do
        piece.CFrame = piece.CFrame + Vector3.new(0, 1.9629, 0)
        wait(.2)
    end
end

function onClicked()
    local gates = game.workspace.GateModel:GetChildren()
    for i, child in ipairs(gates) do
	--here i create a new thread using spawn and places the raiseGate function there
	spawn(function()
        	raiseGate(child)
	end)
	--Notice how I added the .2 from the raiseGate function to take into account how long raiseGate lasts
        wait(.1 + .2)
    end
end
script.Parent.ClickDetector.MouseClick:connect(onClicked)

I added .2 to the wait outside the spawn function because the .2 of raiseGate is in another thread.

AnonymousJun 18, 2019Edited Jun 18, 2019Permalink

5 comments

Technical note: "spawn" is a function that creates a coroutine/thread (you aren't "creating a spawn")

AnonymousJun 18, 2019#

You shouldn't create threads when the task can be easily done without them (like chess123mate's answer) because waits are not precise and the thread manager needs to waste processing power managing all your threads.

AnonymousJun 19, 2019#

@hiimgoodpack the question was "Can a Function be CALLED AGAIN BEFORE Completion?" which I answered perfectly. though I wouldn't disagree with you either.

AnonymousJun 19, 2019#

What the OP wanted to actually do didn't need you to call a function again before it's done.

AnonymousJun 22, 2019#

You should increase the height of all parts before waiting. To ensure the loop doesn't start a second time before the first time has finished, use debounce: https://developer.roblox.com/articles/Debounce.

local db = false
function onClicked()
	if db then return end
	db = true
    local gates = game.Workspace.GateModel:GetChildren()
	for i = 0, amount do
	    for i, piece in ipairs(gates) do
	        local amount = piece.Order.Value
	        piece.CFrame = piece.CFrame + Vector3.new(0, 1.9629, 0)
	    end
		wait(.2)
	end
	db = false
end
script.Parent.ClickDetector.MouseClick:connect(onClicked)

AnonymousJun 18, 2019Permalink

This discussion is preserved as it was. New answers, comments, and votes are closed.