✓ ANSWER ACCEPTED

How to save that stats of player??

Asked Jan 13, 2019521 views2 answers

It doens't save, I don't know how to fix, there is a major problem with this...

local datastore = game:GetService("DataStoreService")
local CashData = datastore:GetDataStore("CashSavingSystem")
local InBucketData = datastore:GetDataStore("InBucketSavingSystem")

game.Players.PlayerAdded:Connect(function(plr)
	local folder = Instance.new("Folder", plr)
	folder.Name = "leaderstats"
	local cd = Instance.new("IntValue", folder)
	cd.Name = "Cash"
	cd.Value = CashData:GetAsync(plr.userId) or 0
	local ib = Instance.new("IntValue", folder)
	ib.Name = "InBucket"
	ib.Value = InBucketData:GetAsync(plr.userId) or 0
	CashData:SetAsync(plr.userId, cd.Value)
	InBucketData:SetAsync(plr.userId, ib.Value)
	
	cd.Changed:connect(function()
		CashData:SetAsync(plr.userId, cd.Value)
	end)
	ib.Changed:connect(function()
		InBucketData:SetAsync(plr.userId, ib.Value)
	end)
end)

AnonymousJan 13, 2019

3 comments

Is API on?

AnonymousJan 13, 2019#

Yes, API is on.

AnonymousJan 13, 2019#

Don't save to the DataStore every time 'cd' or 'ib' changes. You will exceed data store limits this way. Instead, save at important points like when the player leaves: https://developer.roblox.com/articles/Datastore-Errors

AnonymousJan 13, 2019#

2 answers

✓ Accepted answer

Most developers have troubles saving player stats to DataStore. To properly save data, you must know that there are limits to how much data the server can store per n number of minutes. Visit this link to view more about DataStore limits.

To start off, here's a simple example of saving and loading player stats.

local DataStoreService = game:GetService('DataStoreService')
local DataStore = DataStoreService:GetDataStore('TestDataStore')

local function onPlayerAdded(player)
	local leaderstats = Instance.new('Folder', player)
	leaderstats.Name = 'leaderstats'

	local cash = Instance.new('IntValue', leaderstats)
	cash.Name = 'Cash'

	local playerData = DataStore:GetAsync(player.UserId) --getting players' data; nil if no data
	if not playerData then
		cash.Value = 50 --initial player cash
	else
		cash.Value = playerData
	end
end

local function onPlayerRemoving(player)
	DataStore:SetAsync(player.UserId, player.leaderstats['Cash'].Value)
end

game.Players.PlayerAdded:Connect(onPlayerAdded)
game.Players.PlayerRemoving:Connect(onPlayerRemoving)

Data should be saved when the player leaves, constantly storing data could result in data loss or error. DataStore functions should also be wrapped inside pcall. View this link for more information on pcall.

AnonymousJan 13, 2019Edited Jan 14, 2019Permalink

1 comment

To ensure data is saved put an BindToClose evnt

AnonymousJan 14, 2019#

The problem is that player.userId contains a read only integer while data store requires strings for its arguments. Try replacing replacing it with tostring(plr.userId)

So like this

local datastore = game:GetService("DataStoreService")
local CashData = datastore:GetDataStore("CashSavingSystem")
local InBucketData = datastore:GetDataStore("InBucketSavingSystem")

game.Players.PlayerAdded:Connect(function(plr)
    local folder = Instance.new("Folder", plr)
    folder.Name = "leaderstats"
    local cd = Instance.new("IntValue", folder)
    cd.Name = "Cash"
    cd.Value = CashData:GetAsync(tostring(plr.userId)) or 0
    local ib = Instance.new("IntValue", folder)
    ib.Name = "InBucket"
    ib.Value = InBucketData:GetAsync(tostring(plr.userId)) or 0
    CashData:SetAsync(tostring(plr.userId), cd.Value)
    InBucketData:SetAsync(tostring(plr.userId), ib.Value)

    cd.Changed:connect(function()
        CashData:SetAsync(tostring(plr.userId), cd.Value)
    end)
    ib.Changed:connect(function()
        InBucketData:SetAsync(tostring(plr.userId), ib.Value)
    end)
end)

A little side note to, you shouldn't save every time the players money changes but instead save when the player leaves as its much more efficient. So something like this:


local datastore = game:GetService("DataStoreService")
local CashData = datastore:GetDataStore("CashSavingSystem")
local InBucketData = datastore:GetDataStore("InBucketSavingSystem")

game.Players.PlayerAdded:Connect(function(plr)
    local folder = Instance.new("Folder", plr)
    folder.Name = "leaderstats"
    local cd = Instance.new("IntValue", folder)
    cd.Name = "Cash"
    cd.Value = CashData:GetAsync(tostring(plr.userId)) or 0
    local ib = Instance.new("IntValue", folder)
    ib.Name = "InBucket"
    ib.Value = InBucketData:GetAsync(tostring(plr.userId)) or 0
    CashData:SetAsync(tostring(plr.userId), cd.Value)
    InBucketData:SetAsync(tostring(plr.userId), ib.Value)

    game.Players.PlayerRemoving:Connect(function()
	CashData:SetAsync(tostring(plr.userId), cd.Value)
	InBucketData:SetAsync(tostring(plr.userId), ib.Value)
    end)
end)

AnonymousJan 13, 2019Edited Jan 13, 2019Permalink

2 comments

You should always use the UserId of the player and never the name. This is because Names of players are able to change.

AnonymousJan 13, 2019#

Noted and fixed

AnonymousJan 13, 2019#

This discussion is preserved as it was. New answers, comments, and votes are closed.