How to stop errors with if statement arguements?

Hello,

I am trying to stop it from erroring when it cannot find the object "Config" but I haven't been able to figure it out.

local user = tool.Parent 
local ray = Ray.new(tool.MuzzleFlash.CFrame.p, (target - tool.MuzzleFlash.CFrame.p).unit*300)
local hit, position = game.Workspace:FindPartOnRay(ray, user)

local TargetObj = hit and hit.Parent.Parent:FindFirstChild("Config")
local DamageObj = TargetObj
	if DamageObj then 
		DamageObj.Hull.Value = DamageObj.Hull.Value - 25
	end

Any help would be appreciated

AnonymousSep 30, 2018

2 comments

try adding "if TargetObj then" and also is hit nil?

AnonymousSep 30, 2018#

try adding "if TargetObj then" and also is hit nil?

AnonymousSep 30, 2018#

✓ Accepted answer

Line 5 is a little bit confusing hit and hit.Parent.Parent:FindFirstChild("Config") will return true or false and set that to the variable TargetObj then on the next line you're simply creating a new variable for the same value, perhaps you just want to remove hit and?

local user = tool.Parent 
local ray = Ray.new(tool.MuzzleFlash.CFrame.p, (target - tool.MuzzleFlash.CFrame.p).unit*300)
local hit, position = game.Workspace:FindPartOnRay(ray, user)

local TargetObj = hit.Parent.Parent:FindFirstChild("Config")
if TargetObj then 
    TargetObj .Hull.Value = TargetObj .Hull.Value - 25
end

AnonymousSep 30, 2018Permalink

11 comments

Ah, still didnt work. "Hull is not a member of Folder". Some of my models have the value, some dont. So ya, the errors are just annoying. thanks for trying.

AnonymousSep 30, 2018#

Ok then check that too if you want to. [If TargetObj and TargetObj:FindFirstChild("Hull") then].

AnonymousSep 30, 2018#

Thanks man, you did it. Days of headaches figuring this out, thanks!

AnonymousSep 30, 2018#

It wouldn't return true or false, it would return either nil or the Config child

AnonymousSep 30, 2018#

Correct but an object will evaluate as truthy whereas nil will not

AnonymousSep 30, 2018#

Yes, but I don't know how that relates... wouldn't this script error if hit turned out to be nil? That was the whole point of the and statement in the original script

AnonymousSep 30, 2018#

No since [if nil then] is the same as [if false then] but trying to do [nil.Hull] will error, hence the check first.

AnonymousSep 30, 2018#

TargetObj = hit.Parent.Parent -> if hit is nil then it will be incapable of indexing hit, I don't see a "if hit" statement anywhere in your script

AnonymousSep 30, 2018#

I'm not talking about Hull at all, I mean that hit returned from FindPartOnRay might be nil, therefore the TargetObj assignment will error

AnonymousSep 30, 2018#

Ah forgive me, yes that could happen and error. I didn't look at it closely when copying his code.

AnonymousSep 30, 2018#

No worries

AnonymousSep 30, 2018#

How to stop errors with if statement arguements?

2 comments

1 answer

11 comments