There are no errors shown and i don't have any idea how to fix this script. Everything is where should it be, so it's not because of the objects.
local RepStorage = game:GetService("ReplicatedStorage")
local Remote = RepStorage:WaitForChild("Remote")
local LocalRemote = Remote:WaitForChild("GunSeller")
LocalRemote.OnServerEvent:connect(function(player, gunvalue, price)
local gun = RepStorage.Data_Stores.SavedGuns:FindFirstChild(player.Name):WaitForChild(gunvalue).Value
local givemoney = RepStorage.Data_Stores.Currency:FindFirstChild(player.Name):WaitForChild("Money").Value
gun = gun - 1 -- Doesn't Change
givemoney = givemoney + price -- Doesn't Change
end)

3 comments
connect is deprecated use Connect
There is no diference.
The difference is their state. connect is deprecated whilst Connect is not.