GUI text not updating at all. Why isn't it?

I have this generator, which as a concept generates energy. I need this GUI to update to show the player how much energy they have.

This is my code:

local text = script.Parent
local display = game.Workspace.Generator.ClickButton.ClickDetector.PowerCore.Energy.Value


while wait() do
	dis = tostring(display)
	text.Text = "Total energy: " .. dis
end

I put the variable dis to update every tick so the value would change depending on how much energy the player has. It stays at 0.

Because youre not updating the display variable(it only gets assigned once, at the start of the script). put it inside the while true loop so it gets updated. Ill edit this answer later if it isn't sufficient since I'm using a phone It should also be in local script because playergui is invisible to server

Updated Code

local text = script.Parent
 

while wait() do
local display = game.Workspace.Generator.ClickButton.ClickDetector.PowerCore.Energy.Value --always updates with the energy value
dis = tostring(display)
text.Text = "Total energy: " .. dis
end

I recreated the situation in studio, and it works fine. Make sure to put local script INSIDE the textlabel

The reason for this is when you declare the value at the start of the script

Original Code

local text = script.Parent
local display = game.Workspace.Generator.ClickButton.ClickDetector.PowerCore.Energy.Value --only gets assigned once

while wait() do
dis = tostring(display)
text.Text = "Total energy: " .. dis
end

Suppose the starting value of energy is 3. Since the variable display only gets assigned the value once (When the game starts) The variable will keep the value 3 until it is updated again. If you put it inside the while loop like in the first given code, the variable gets updated constantly with the Energy Value

In your script, you write:

local text = script.Parent
local display = game.Workspace.Generator.ClickButton.ClickDetector.PowerCore.Energy.Value

while wait() do
    dis = tostring(display)
    text.Text = "Total energy: " .. dis
end

The error here, is that display = 0 forever. In other words, the value associated with the variable display does not update.

You need to place the variable display under a loop function that rechecks the value of the energy repeatedly. So to do that, you just simply move it under the while do loop function that you have already written.

local text = script.Parent

while wait() do
	local display = game.Workspace.Generator.ClickButton.ClickDetector.PowerCore.Energy.Value
    dis = tostring(display)
    text.Text = "Total energy: " .. dis
end

Problem solved.