Door that moves (with button) not sure what I did wrong?

new problem, right so

DoorHold = game.Workspace.doorfather.DoorHold

local open=true
local door = script.Parent.Parent
script.Parent.mouseClick:connect(function()
    if open then 
        open=false
    door.CFrame = CFrame.new(DoorHold.Position)
        door.BrickColor=script.PartkeypadY.Value
    else
        open=true
        door.CFrame = CFrame.new(TargetPosition + Vector3.new(0,10,0))
        door.BrickColor=script.PartkeypadX.Value
    end
end)

these are photos of where all my stuff is located

i get the error

22:05:58.124 - Stack End 22:06:06.191 - Position is not a valid member of Model 22:06:06.192 - Stack Begin 22:06:06.193 - Script 'Workspace.doorfather.Keypad.Partkeypad.ClickDetector.Script', Line 8

Problem: probably that you aren't assigning to .Position on lines 6 or 12. Also note that using CFrame is much better, since if someone's standing in the door, CFrame will ignore them and "close" it anyway (preventing people from keeping it open indefinitely).

Minor notes:

• You have a lot of script.Parent.Parent. Consider replacing that with a variable (like "door" or "house" or "model" or whatever it is). As farrizbb suggests, you might also consider making the more specific variables.
• You never need to say + Vector3.new(0, 0, 0), as anything plus zero is unchanged
• You don't need to say "== true". By default, any non-false/nil value is considered true.
• Using local variables is slightly faster and good practice to be in

Resulting script:

local open=true
local door = script.Parent.Parent
script.Parent.mouseClick:connect(function()
    if open then 
        open=false
	door.CFrame = CFrame.new(Doorgay.Position)
        door.BrickColor=script.ButtonY.Value
    else
        open=true
       	door.CFrame = CFrame.new(TargetPosition + Vector3.new(0,10,0))
        door.BrickColor=script.ButtonX.Value
    end
end)

Notice the significant decrease in the amount of text you have to read/write. Further, it is easy to modify the variables in the first two lines (ex maybe the script is moved to a different location and you only need to access script.Parent instead of script.Parent.Parent -- in that case, you can do that in a single location (line 2) instead of several).

I have figured it out with the help of the friendly people on the discord. thanks.

local Buttons = {}
for _,a in pairs(script.Parent.Parent.Parent.Button:GetChildren()) do
    if a:IsA('BasePart') then
        table.insert(Buttons, a)
    end
end
local ClickDetector = Instance.new('ClickDetector')
for _,a in ipairs(Buttons) do
	local ClickDetector = Instance.new('ClickDetector', a)
	ClickDetector.MouseClick:connect(function()
		if script.DoorOpen.Value == false then
			script.DoorOpen.Value = true
   			print('Opening Door')
    		for i = 1,25 do
      			for _,a in ipairs(script.Parent.Parent.Parent.DoorHold:GetChildren()) do
					a.CFrame = (a.CFrame + (Vector3.new(0,0.5,0)))
           			wait()
        		end
			end
		else
			script.DoorOpen.Value = false
			 print('Closing Door')
    		for i = 1,25 do
    		    for _,a in ipairs(script.Parent.Parent.Parent.DoorHold:GetChildren()) do
					a.CFrame = (a.CFrame - (Vector3.new(0,0.5,0)))
					wait()
        		end
			end
    	end	
	end)
end

print(#Buttons)