How to make script work for all ImageButtons inside of a GUI?

How would making this work for ALL ImageButtons in a GUI work? I'd like to have one main script instead of having to copy and paste it inside of all the ImageButtons. It clones a ParticleEmitter and Sound from inside of the Script and removes them after some time when the ImageButton is clicked.

Not too sure how I'd go about laying it out or if I'm doing it right.

for i,c in pairs(GetChildren()) do
	if c:IsA'ImageButton' then
	c.MouseButton1Click:connect(function()
function onClicked()
	local particle = script.ParticleEmitter:Clone()
	game:GetService("Debris"):AddItem(particle, .35)
	particle.Parent=Character.Torso
	particle.Enabled = true
	
	wait(.35)
	local sound = script.TransformSound:Clone()
	game:GetService("Debris"):AddItem(sound, 3)
	sound.Parent = Character
	sound:Play()
	wait(3)

end 
script.Parent.MouseButton1Click:connect(onClicked)

AnonymousJan 17, 2017Edited Jan 17, 2017

✓ Accepted answer

This script should work You binded same function two times I mean You did something like this OnClicked > OnClicked > Function This should work

local Character = game.Players.LocalPlayer.Character
function check(holder)
for i,c in pairs(holder:GetChildren()) do
    if c:IsA'ImageButton' then
        c.MouseButton1Click:connect(function()
             local particle = script.ParticleEmitter:Clone()
             game:GetService("Debris"):AddItem(particle, .35)
             particle.Parent=Character.Torso
             particle.Enabled = true

             wait(.35)
             local sound = script.TransformSound:Clone()
             game:GetService("Debris"):AddItem(sound, 3)
             sound.Parent = Character
             sound:Play()
             wait(3)
        end)
    end
end 
end
for _, i in pairs(script.Parent:GetChildren()) do
 if string.upper(string.sub(i.Name, 1, 1)) == "C" then
  check(i)
 end
end
for _, i in pairs(script.Parent.Parent:GetChildren()) do
 if string.upper(string.sub(i.Name, 1, 1)) == "C" then
  check(i)
 end
end

Updated script This should be placed in LocalScript

AnonymousJan 17, 2017Edited Jan 17, 2017Permalink

18 comments

I have the hierarchy like this: AlbedoGUI - Main - C1, I'd like for it to check through any page beginning with C. I tried this: local holder = script.Parent['C'] but not sure if it's correct. Also, it says "Unknown global Character"

AnonymousJan 17, 2017#

The GUI is inside of the ReplicatedStorage, and is taken from there when a tool is used.

AnonymousJan 17, 2017#

At the start add local Character = game.Players.LocalPlayer.Character

AnonymousJan 17, 2017#

also script might be LocalScript so it will work (about this ['C'] You did this alright)

AnonymousJan 17, 2017#

Updated script. It should work now. I didnt know that there isnt definied Character variable. Sorry

AnonymousJan 17, 2017#

defined*

AnonymousJan 17, 2017#

It says that C is not a valid member of Frame

AnonymousJan 17, 2017#

are You sure that There is also C thing in Parent of script ( are u sure that there is a thing named C in the same place where script is held)?

AnonymousJan 17, 2017#

I have many Frames (pages of GUI) named like C1, C2. The script is inside of a Frame called Main inside of AlbedoGUI.

AnonymousJan 17, 2017#

and is C frame in Main frame too?

AnonymousJan 17, 2017#

if no then set location to script.Parent.Parent["FULL NAME OF FRAME WHERE ARE IMAGEBUTTONS"]

AnonymousJan 17, 2017#

change this FULL NAME... to the full name of the C frame

AnonymousJan 17, 2017#

There's no frame named just C, I'd like it to check for any frames with C at the beginning, like the frames C1 and C2, not sure how to do it.

AnonymousJan 17, 2017#

Oh so there are placed in the gui? and in these frames are imagebuttons Alright let me update script

AnonymousJan 17, 2017#

here You go. it might work now

AnonymousJan 17, 2017#

Thanks a bunch for your help, I really appreciate it a lot. Does the bottom part need to be there twice because it seems to work with it there just once?

AnonymousJan 17, 2017#

uhh keep it :) just for making sire that works. If its possible then I appreciate if You click "Accept answer" so dat will be nice :) thank You at all

AnonymousJan 17, 2017#

Thank You very much

AnonymousJan 17, 2017#

How to make script work for all ImageButtons inside of a GUI?

1 answer

18 comments