Minimap help

To start with, you might want to initialize torso2 below target, just so that future-you or anybody else that reads your code understands that torso2 is set during the running of the code, changing the outputs of x() and y(). Also, look into generic for loops. They're simpler to use than numeric for loops if you're iterating through a table.

An error I can see already is that your players table is only initialized and never updated for when players leave or join. This is easily fixed by re-initializing it every time your loop runs.

Also, you do need to destroy the dots every time if you recreate them every time. An easier way to do that is then your nested ifs is to move that code to outside of the first for loop, at which point 'i' will have to be the same as #players, since that is when the loop exits.

You can reduce the line f.Position = script.Parent.Position + UDim2.new(0, 50, 0, 50) - UDim2.new(0, 2.5 , 0, 2.5) + UDim2.new(0, x(), 0, y()) to simply f.Position = script.Parent.Position + UDim2.new(0, 47.5 + x(), 0, 47.5 + y()), since UDim2 is purely additive, unlike CFrame.

You can move line 28 to outside of the loop, since it is never set anywhere else. In fact, you could probably just change that in the actual GUI, unless you mean to change it elsewhere in the script.

Finally, your second while loop will never run, as the first while loop will never end. In order to run it, you'll need to run it as a coroutine.

Now on to your actual problem!

(First of all, I'm taking that your minimap is a simple, 2D, top-down minimap, not something too fancy.)

What would be easiest, in my opinion, would be to rotate script.Parent.Parent.GUI by the player's Heading converted into degrees, and then rotating each dot (including the player'ss if it's also rotated) an opposite amount so that they remain 'vertical'.

If that doesn't work for you, here's a function that will return how much to translate a secondary point around a given center point, both in Vector2 format, given the amount to rotate by in radians:

function rot(center, point, deg)
	point = (point - center)
	local point_c = point
	local len = point.magnitude
	point = point.unit
	local rad = math.atan2(point.y, point.x)+ deg
	point = Vector2.new(math.cos(rad), math.sin(rad))*len
	return (point-point_c)
end
--Note: At the moment, I can't test this. Let me know if it doesn't work!

To use this, you'll need to get the character's Heading, as shown in the above article I linked to.

After where you set f.Position, you'll need to add:

local rotMod = rot(--[['Center' of minimap]], f.AbsolutePosition, heading)
f.Position = f.Position + UDim2.new(0, rotMod.x, 0, rotMod.y)

And then you should be done!