Scripting HelpersARCHIVE
A little piece of Roblox history. Preserved for everyone, one question at a time.Read about the archive →
All questions/Question #32744
✓ ANSWER ACCEPTED

why does this script only change parent of 1 tool why not all tools in backpack?

Asked 362 views1 answers
script.Parent.Touched:connect(function(hit)
	local human = hit.Parent:FindFirstChild("Humanoid")
	if human ~= nil then
		print("Human Found!")
		local player = game.Players:FindFirstChild(hit.Parent.Name)
		if player ~= nil then
			print("Player Found!")
			local backpack = player:FindFirstChild("Backpack")
			if backpack ~= nil then
				print("Backpack Found!")
				local alltools = backpack:GetChildren()
				for i,v in pairs(alltools) do
					if v.ClassName == "Tool" then
						print("Tool Found!")
						if game.Workspace:FindFirstChild(hit.Parent.Name.. "'s BikePackback") == nil then
							local model = Instance.new("Model")
							model.Name = hit.Parent.Name.. "'s BikePackback"
							model.Parent = game.Workspace
							v.Parent= model
						end
					end
				end
			end
		end
	end
end)

i want this script to move all the stuff that are tools to a different model in workspace when they touch the brick but this script only moves 1 tool to that model not all of them. please help. i dont want this script to move things other then tools to the model in workspace. please help me

Anonymous

1 answer

✓ Accepted answer

The section of your current code with the problem, starting with your line 15.

if game.Workspace:FindFirstChild(hit.Parent.Name.. "'s BikePackback") == nil then --if it doesn't exist
	local model = Instance.new("Model") --make a new one
	model.Name = hit.Parent.Name.. "'s BikePackback"
	model.Parent = game.Workspace
	v.Parent= model --and put the current tool in it
end

The issue is that if the backpack does exist then you do nothing with the tool in the loop.

There are also a few other issues with your code. With what you are trying to do, it is much better to put the if statement after the loop for the tools, rather than inside it.

For generally cleaner code, it is better to make the bikepack a variable rather than trying to find it several times, since you'll need to use it several times. It is a better practice to use the :IsA() method rather than checking the name of the class, and there an optional second argument you can put in an Instance.new() call that lets you define the parent.

Here is a replacement for your lines 12-22.

local pack = game.Workspace:FindFirstChild(hit.Parent.Name.. "'s BikePackback") --get the pack
if pack == nil then --if it doesn't exist
	pack = Instance.new("Model", workspace) --make a new one
	model.Name = hit.Parent.Name.. "'s BikePackback"
end
for i, v in pairs(alltools) do --loop through tools
	if v:IsA("Tool") then --make sure it's a tool
		v.Parent= model --and parent the tool
	end
end

If you have any further questions, feel free to leave a comment.

AnonymousEdited Permalink

This discussion is preserved as it was. New answers, comments, and votes are closed.