Scripting HelpersARCHIVE
A little piece of Roblox history. Preserved for everyone, one question at a time.Read about the archive →
All questions/Question #28169
✓ ANSWER ACCEPTED

Why does this key-hold not holding? You have to keep clicking for it to run.

Asked 196 views1 answers
player = game.Players.LocalPlayer
local mouse = game.Players.LocalPlayer:GetMouse()
mouse.KeyDown:connect(function (key)
	for i, v in pairs(game.Players:GetChildren()) do
	if key == "f" then
	for i = 1,2 do
	if player.Magic.Value <= player.MagicMax.Value then
	player.Magic.Value = player.Magic.Value +1
	end
	end
	end
	end
	
	mouse.KeyUp:connect(function (key)
	if key == "f" then
	end
	end) 
	end)

This is the script. It has no errors. I don't know what I am doing wrong. What it is supposed to do is to increase the magic value as long as the f button is held. Instead it only increases the value by two and it does not continually do it until you let go of f. Instead you have to mash f for it to even go up.

Anonymous

1 comment

0

(Replied)

Anonymous#

1 answer

✓ Accepted answer

Right now, your logic looks like this:

WHEN F FIRST PRESSED
	ADD TO MAGIC

... and that's all.

KeyDown only happens the moment that you begin pressing a key, and right now that's the only time you're adding magic.

This is the design you want:

EVERY MOMENT
	IF F IS CURRENTLY DOWN
		ADD TO MAGIC

The loop then looks like this:

while wait() do
	if F then
		player.Magic.Value = math.min(
			player.MaxMagic.Value,
			player.Magic.Value + 1)
	end
end

We simply have to set F to true when a KeyDown happens and false when a KeyUp happens.

Remember that these connections have to happen before the while loop

local F = false
mouse.KeyDown:connect(function(key)
	if key == "f" then
		F = true
	end
end)
mouse.KeyUp:connect(function(key)
	if key == "f" then
		F = false
	end
end)
AnonymousPermalink

6 comments

0

Thank you so much!

Anonymous#
0

Problem. If i gain magic and then I stop, when i do it again my magic goes up faster

Anonymous#
0

The code that I have written does not do that. Can you post your full code, e.g. in a Hastebin link?

Anonymous#
0

sure

Anonymous#
0

The while loop goes AFTER the event code. It does not start or stop depending on the key events. Look at my code -- I do not have the while in the middle of the key functions.

Anonymous#

This discussion is preserved as it was. New answers, comments, and votes are closed.