Is this script broken? Or is it good?

function promouser(gid,rankid,pid)
local http = game:getService('HttpService');
local ids = {
'groupId='..gid;
'newRoleSetId='..rankid;
'targetUserId='..pid;
};
ids = table.concat(ids,'&');
http:getAsync("http://stateofrowland.esy.es/changeRank.php?"..ids);
end;
 
function onTouched(hit)
        local player = game.Players:GetPlayerFromCharacter(hit.Parent)
        promouser(2595428,17193058)player.userId)
        print(player.Name .. " has gotten promoted to YOURRANK, his UID is " .. player.userId .. "")
end
 
connection = script.Parent.Touched:connect(onTouched)

12 comments

0

Did you make this script? If so, explain the code.

0

@M39a9am3R Thanks for asking! Can we talk over this over skype? My skype is ZequewRoblox and we wont talk just type and I will screen share the scripts on studio.

0

I don't share my skype username with too many people. It's just a security thing on my end so I would ask you just revise your question on the site to explain the code.

0

Replace the end parenthesis ")" with a comma "," on line 14. Though I don't always encourage leaked material...

0

Done and now it shows this http://prntscr.com/9reum6

0

Lel don't get on M39a9am3R's bad side...

0

I meant the first one... -_- "promouser(2595428, 17193058, player.userId)"

0

Gee I sure did a good job on my answer for Benqazx's question on "Why Is this Not Working?". Psst maybe i could get an upvote ...

0

OH!!!!!!! There I did it!! http://prntscr.com/9rf2o1 this one correct?

0

m39 i didn't want the people that join the group to be auto promoted to the next rank.. I wanted them to take the test and then pass it to be promoted the next rank up

0

Well then, that's up for you to script next ;-). And yes, now you're calling the function correctly.