Can you help me with my Giver Script?

I am using this script for my Giver:

local debounce = false

function getPlayer(humanoid) 
local players = game.Players:children() 
for i = 1, #players do 
if players[i].Character.Humanoid == humanoid then return players[i] end 
end 
return nil 
end 

function onTouch(part) 

local human = part.Parent:findFirstChild("Humanoid") 
if (human ~= nil) and debounce == false then

debounce = true

local player = getPlayer(human) 

if (player == nil) then return end 

game.Lighting.HyperLaser:clone().Parent = player.Backpack

wait(5)
debounce = false
end
end


script.Parent.Touched:connect(onTouch)

This used to work but all the sudden it doesnt work at all :( I have no idea what is wrong can you guys help me?

AnonymousJul 3, 2015

1 comment

Any error in the output?

AnonymousJul 3, 2015#

✓ Accepted answer

There are a couple of mistakes, I did a complete rewrite of the script, made it more efficient, and more organized and easier to read. Consider reading the wiki this will help you a lot.

I have explained each and every thing to the best of my ability, hope I make everything clear for you.

Here's the script:

local debounce = false

function onTouch(hit) 
	local player = game.Players:GetPlayerFromCharacter(hit.Parent) -- getting the player from his character
	if player.Character and not debounce then -- checking if the player's character exists and the debounce == false
		local char = player.Character  -- defining character for later use
		debounce = true 
		local weapon = game.Lighting.HyperLaser:clone() 
		weapon.Parent = char -- parenting the weapon to character
		wait(5)
		debounce = false
	end	
end

script.Parent.Touched:connect(onTouch)

Note: I highly recommend using ServerStorage, rather than Lighting, but I used Lighting anyway since you already had it like that.

Hope it helps!

AnonymousJul 3, 2015Edited Jul 3, 2015Permalink

6 comments

I have a custom backback that disables the OG backpack and that is why it doesnt work, is there anyway to make it compatable?

AnonymousJul 3, 2015#

I believe you can parent the tool to the player's character, that would make the character have it already equipped. Unequipping and equipping it again would belong to the custom backpack system you already made.

AnonymousJul 3, 2015#

Could you edit your script on how I would do that? Sorry I dont need to be demanding I jsut havnt really handle the Core GUI's at all....

AnonymousJul 3, 2015#

Edited

AnonymousJul 3, 2015#

Thanks, It worked great! I really appreciate the fact that you told me what the script did, so I can learn from it!

AnonymousJul 3, 2015#

No problem! Happy I could help

AnonymousJul 3, 2015#

Can you help me with my Giver Script?

1 comment

1 answer

6 comments