So I'm currently working on a Rank system that is determined by the players team, and level but for some reason when It re-assigns the player's rank, when they level up it does not stick and continues to run off of their previous team's ranks. What is happening?
---//Services\\---
local ReplicatedStorage = game:GetService("ReplicatedStorage")
--//ServiceChildren\\--
local USRankHandler = require(ReplicatedStorage.RankHandler:WaitForChild("USRankHandler")) ---module script
local VRankHandler = require(ReplicatedStorage.RankHandler:WaitForChild("VRankHandler")) ---module script
---//USRankHandler\\---
game.Players.PlayerAdded:Connect(function(player)
if player.TeamColor == BrickColor.new("Cyan") then
player:WaitForChild("leaderstats").Rank.Value = USRankHandler.Rank(player:WaitForChild("leaderstats2").Level.Value) ---Rank is a StringValue level is a IntValue
player.leaderstats2.Level:GetPropertyChangedSignal("Value"):Connect(function()
player:WaitForChild("leaderstats").Rank.Value = USRankHandler.Rank(player:WaitForChild("leaderstats2").Level.Value)
end)
end
end)
--//USRankTeamChange\\--
game.Players.PlayerAdded:Connect(function(player)
player:GetPropertyChangedSignal("TeamColor"):Connect(function()
if player.TeamColor == BrickColor.new("Cyan") then
player:WaitForChild("leaderstats").Rank.Value = USRankHandler.Rank(player:WaitForChild("leaderstats2").Level.Value)
end
end)
end)
---//VRankHandler\\---
game.Players.PlayerAdded:Connect(function(player)
if player.TeamColor == BrickColor.new("Bright red") then
player:WaitForChild("leaderstats").Rank.Value = VRankHandler.Rank(player:WaitForChild("leaderstats2").Level.Value) ---Rank is a StringValue level is a IntValue
player.leaderstats2.Level:GetPropertyChangedSignal("Value"):Connect(function()
player:WaitForChild("leaderstats").Rank.Value = VRankHandler.Rank(player:WaitForChild("leaderstats2").Level.Value)
end)
end
end)
--//VRankTeamChange\\--
game.Players.PlayerAdded:Connect(function(player)
player:GetPropertyChangedSignal("TeamColor"):Connect(function()
if player.TeamColor == BrickColor.new("Bright red") then
player:WaitForChild("leaderstats").Rank.Value = VRankHandler.Rank(player:WaitForChild("leaderstats2").Level.Value)
end
end)
end)
--###----------[[VARIABLES]]----------###--
local USRanks = {
"Private",
"PFC",
"Corporal",
"Sergeant",
"Staff Sergeant",
"Technical Sergeant",
"First Sergeant",
"Master Sergeant",
"Second Lieutenant",
"First Lieutenant",
"Captain",
"Major",
"Lieutenant Colonel",
"Colonel",
"Brigadier General",
"Major General",
"Lieutenant General",
"General",
"General of the Army";
}
--###----------[[SETUP]]----------###--
return {
Rank = function(MemberRank)
if (MemberRank > 20) then
return MemberRank .. "?CINC?"
elseif (MemberRank == 20) then
return "?CINC?"
end
---------------
return USRanks[MemberRank]
end
}
--###----------[[VARIABLES]]----------###--
local VRanks = {
"Binh nhì",
"Binh nh?t",
"H? s?",
"Trung s? ",
"Trung Snv.",
"Trung Skt.",
"Th??ng s?",
"Thi?u úy",
"Trung úy",
"Th??ng úy",
"??i úy",
"Thi?u tá",
"Trung tá",
"Th??ng tá",
"??i tá",
"Thi?u t??ng",
"Trung t??ng",
"Th??ng t??ng",
"??i t??ng";
}
--###----------[[SETUP]]----------###--
return {
Rank = function(MemberRank)
if (MemberRank >= 20) then
return MemberRank .. "?CINC?"
elseif (MemberRank == 20) then
return "?CINC?"
end
---------------
return VRanks[MemberRank]
end
}
Thank you, Vincent
P.S If you need the module scripts please comment asking! :) Also sorry if the code is a mess.
8 comments
It is better if you just compare the Team Objects than their BrickColors. The dual use of 'PlayerAdded' is redundant, and can be additionally handled within the original Callback; you don't actually check for a difference either, both functions read for Cyan, which makes it again unnecessary.
Another thing to note is the fact that load-latency isn't a concern on the Server. The leaderstats folder isn't going anywhere, so you don't need to continuously yield for it. You also should be allocating the Instance if you're going to refer to it several times.
I am struggling to understand your description of the problem. Could you please provide an example of what's going wrong, as well as the ModuleScripts responsible for determining the Player's Rank.
I provided the module scrips.
From your first comment, when I got rid of the 'PlayerAdded' from where I thought you where talking about(TeamChange stuff) I noticed that it would not work at all I'm required to do 'PlayerAdded' or it just wont work.
And personally for me it's easier to use 'TeamColor'. As I just find it easier to use when changing teams.
I am willing to Contact you over discord.
And I have no Idea on how to use Team, but I tried to compare it and it did not work at all.