What do I do about gsub not formatting properly?

Try this pattern

string.gsub("|--||--||--|--|", "%-%-", '=')

Your attempt does not work because - is a magic pattern in string formatting which is described in the wiki as match as few of the preceding character class as possible, since you need to replace the - character instead, you need to use the % operator which turns any special character after it into just a character.