? Help on Cash for different Rank.

Hello there, I am trying to make a Cash for a different Rank in my game. This is my script in ServerScriptService:

local players = game:GetService("Players")

players.PlayerAdded:Connect(function(plr)

local fol = Instance.new("Folder", plr)
fol.Name = "leaderstats"

local Cash = Instance.new("IntValue", fol)
Cash.Name = "Yuan"
Cash.Value = 5

local Rank = Instance.new("StringValue", fol)
Rank.Name = "Rank"
Rank.Value = "Frail"

while true do
	wait(100)
	Cash.Value = Cash.Value + 1
end

while true do
if Cash.Value == 500 then
	Rank.Value = "Loark"
		wait(1)
	end
end

end)

Any suggestions are open. Thank you and stay safe.

Your loop isn't asynchronous, therefore your main thread will yield at increasing the Cash value indefinitely.

Threading is an option, but there is a much more efficient approach to this:

--###----------[[SERVICES]]----------###--
local Players = game:GetService("Players")



--###----------[[FUNCTIONS]]----------###--
local function InstantiateLeaderstats(Player)
	local Leaderstats = Instance.new("Folder")
	---------------
	local Rank = Instance.new("StringValue")
	local Cash = Instance.new("IntValue")
	---------------
	Leaderstats.Name = "leaderstats"
	---------------
	Rank.Name = "Rank"
	Rank.Value = "Frail"
	---------------
	Cash.Name = "Yuan"
	Cash.Value = 350
	---------------
	Rank.Parent = Leaderstats
	Cash.Parent = Leaderstats
	---------------
	Leaderstats.Parent = Player
	---------------
	return Leaderstats
end


local function OnPlayerEntered(Player)
	local Leaderstats = InstantiateLeaderstats(Player)
	---------------
	local Cash = Leaderstats.Yuan
	local CashUpdated;
	---------------
	CashUpdated = Cash:GetPropertyChangedSignal("Value"):Connect(function()
		---------------
		if (Cash.Value == 500) then
			---------------
			Leaderstats.Rank.Value = "Loark"
			---------------
			CashUpdated:Disconnect()
		end
	end)
	---------------
	while (true) do
		wait(100)
		---------------
		Cash.Value += 1
	end
end



--###----------[[SETUP]]----------###--
Players.PlayerAdded:Connect(OnPlayerEntered)

It still did not work, though thanks for trying to answer my problem!