Data Saving based on the other IntValue?

So I have 2 values, they are just int values, without leaderstats. Which value i save last via Server Side, the other value is going to be set to that value too.

Eg if i do theCash's value to 100 then I do theWins's Value to 500

When i reload the game, both of them will be 500, why?

local DS = game:GetService("DataStoreService"):GetDataStore("a")
game.Players.PlayerAdded:Connect(function(player)
	local theCash = Instance.new("IntValue",player)
	theCash.Name = "theCash"
	theCash.Value = DS:GetAsync(player.UserId) or 0
	
	local theWins = Instance.new("IntValue", player)
	theWins.Name = "theWins"
	theWins.Value = DS:GetAsync(player.UserId) or 0
	
	local function saveTheData(theData)
		theData.Changed:Connect(function()
			DS:SetAsync(player.UserId, theData.Value)
		end)
	end
	
	saveTheData(theCash)
	saveTheData(theWins)

end)

First of all that Instance.new constructor is deprecated, second you should always use pcall to for network calls, as they can fail ans which would reset someone points to zero here. Also you dont need here an inner function

And the reason both would be 500 is because you use the same key to store the values.

you are overwriting the cash value with the wins value

Solution use different keys

local DS = game:GetService("DataStoreService"):GetDataStore("a")

local function saveTheData(key, theData)
        theData.Changed:Connect(function()
            DS:SetAsync(key, theData.Value)
        end)
    end

game.Players.PlayerAdded:Connect(function(player)
    local theCash = Instance.new("IntValue",player) --bad
    theCash.Name = "theCash"
    theCash.Value = DS:GetAsync(player.UserId.."-cash") or 0 -- no pcall

    local theWins = Instance.new("IntValue", player)
    theWins.Name = "theWins"
    theWins.Value = DS:GetAsync(player.UserId.."-wins") or 0

    saveTheData(player.UserId.."-cash", theCash)
    saveTheData(player.UserId.."-wins", theWins)

end)

You're saving two int values in the same key of the data store, look:

local DS = game:GetService("DataStoreService"):GetDataStore("a")
game.Players.PlayerAdded:Connect(function(player)
    local theCash = Instance.new("IntValue",player)
    theCash.Name = "theCash"
    theCash.Value = DS:GetAsync(player.UserId) or 0 -- You're getting from the data store DS + user ID

    local theWins = Instance.new("IntValue", player)
    theWins.Name = "theWins"
    theWins.Value = DS:GetAsync(player.UserId) or 0 -- You're getting from the data store DS + user ID

    local function saveTheData(theData)
        theData.Changed:Connect(function()
            DS:SetAsync(player.UserId, theData.Value)
        end)
    end

    saveTheData(theCash)
    saveTheData(theWins)

end)

What I recommend doing is, atributting a aditional key to the user ID, that defines if its cash or wins, see:

local DS = game:GetService("DataStoreService"):GetDataStore("a")
game.Players.PlayerAdded:Connect(function(player)
    local theCash = Instance.new("IntValue",player)
    theCash.Name = "theCash"
    theCash.Value = DS:GetAsync(player.UserId.. "-cash") or 0 -- You're getting from the data store DS + user ID + cash key

    local theWins = Instance.new("IntValue", player) 
    theWins.Name = "theWins"
    theWins.Value = DS:GetAsync(player.UserId.."-wins") or 0-- You're getting from the data store DS + user ID + wins key


    local function saveTheData(theData)
        theData.Changed:Connect(function()
            DS:SetAsync(player.UserId, theData.Value)
        end)
    end

    saveTheData(theCash)
    saveTheData(theWins)

end)

game.Players.PlayerRemoved:Connect(function(player)
       local theCash = player.theCash.Value
       local theWins = player.theWins.Value

       DS:SetAsync(player.UserId.."-cash", theCash)
       DS:SetAsync(player.UserId.."-wins", theWins) -- Setting async the values and its respective keys.
end)