Scripting HelpersARCHIVE
A little piece of Roblox history. Preserved for everyone, one question at a time.Read about the archive →
All questions/Question #113741
✓ ANSWER ACCEPTED

My argument doesn't works? (player.Name) Please help

Asked 489 views2 answers

First of all, I am not an English speaker, so... sorry if my English is difficult to understand :(

Well... Im trying to make a script that execute a LocalScript (Via RemoteEvent), The LocalScript works to remove every animation that the player has and it works BUT here is my problem:

ServerScript, inside of the seat. (Execute the LocalScript when the player Jumps out of the seat):

game.Players.PlayerAdded:Connect(function(player) --My Possible problem
	local plr = game.Players:WaitForChild(player.Name) --My Possible problem
	local Seat = script.Parent
	local humanoid = nil
	local function sat()
		if humanoid == nil then
			humanoid = Seat.Occupant
			return
		end
		wait(3)
		game:GetService("ReplicatedStorage"):WaitForChild("RemoteEvent"):FireClient(plr)--My Possible problem
		humanoid = nil
	end
	
	Seat:GetPropertyChangedSignal("Occupant"):Connect(sat)
end)

LocalScript (StarterPlayerScripts):

game:GetService("ReplicatedStorage"):WaitForChild("RemoteEvent").OnClientEvent:Connect(function() 
	local Humanoid = game.Players.LocalPlayer.Character.Humanoid
	local ActiveTracks = Humanoid:GetPlayingAnimationTracks()
	for _,v in pairs(ActiveTracks) do
		v:Stop()
	end
end)

So, when I try the game, It works, The LocalScript Stop all the animations that the player has when the player jumps out of the seat BUT when I play in a LocalServer (2 Players) I noticed that when some player jump out of the seat, (I guess the ServerScript) stops ALL PLAYERS animations instead of the animations of the player who was sitting on that seat.

I looked in the Dev Hub and some guy said that if we put: (player.Name) It will execute the script just for that specific Client who sat in the seat. (Im not sure about it because its doesn't works for me). Thats all.

Please somebody answer me, If you need more details, tell me.

AnonymousEdited

6 comments

0

I would like you edit your :FireClient(plr) to :FireClient(player, plr) and in Local Script add this line in line 2, if plr == game.Players.LocalPlayer.Name then and your code

Anonymous#
0

Also add plr parameter in OnClientEvent

Anonymous#
0

@BestCreativeBoy well i did everything you told me, i tried the game but now nothing happens, animations are not removed. (There is no error in the output)

Anonymous#
0

And I think I shouldn't edit the LocalScript because I don't think the problem Is in the LocalScript

Anonymous#
0

hello?

Anonymous#
0

Check the code again, I made an error. Now, it should work.

Anonymous#

2 answers

✓ Accepted answer

I think I might have found the error. You are accessing the player parameter from the PlayerAdded Event. And, that you should not do, as it will fire everyone on the server.

In order to prevent this, you can get the Player, who is occupying the seat.

local hum = Seat.Occupant -- Gets the humanoid of the player
local char = hum.Parent -- Get the character of the player
local plr = game.Players:GetPlayerFromCharacter(char) -- Gets the player

And this is what it must look in your code :

game.Players.PlayerAdded:Connect(function() 
    local Seat = script.Parent
    local humanoid = nil
    local function sat()
        if humanoid == nil then
            humanoid = Seat.Occupant
            return
        end
	local char = humanoid.Parent 
	local plr = game.Players:GetPlayerFromCharacter(char) 
	
		if plr then
	        wait(3)
	        game:GetService("ReplicatedStorage"):WaitForChild("RemoteEvent"):FireClient(plr) 
	        humanoid = nil
		end
    end

    Seat:GetPropertyChangedSignal("Occupant"):Connect(sat)
end)

Lemme know if it helps!

AnonymousEdited Permalink

11 comments

0

The output says: FireClient: player argument must be a Player object

Anonymous#
0

Put "if plr then" before line 12 and put "end" on line 15

Anonymous#
0

Put "if plr then" before line 12 and put "end" on line 15

Anonymous#
0

It also didn't work but there was no error in the output

Anonymous#
0

(btw, It didn't remove any animation)

Anonymous#
0

If the plr value is nil, the further code won't execute. Also, there is one more way, i.e., by using Touched event and getting the player from there. Try using that

Anonymous#
0

I am sorry all, I made a follish error. Check the script again. It might work now

Anonymous#
0

*foolish

Anonymous#
0

Script:10: attempt to index nil with 'Parent'. I guess Parent doesn't works with Occupant

Anonymous#
0

Oh thank you! I mean it didn't worked but I just removed Line 09 and replaced "hum" By "humanoid" Because of the Line 06

Anonymous#
0

Edited the script for other with similar issue

Anonymous#

Ok so Instead of:

game.Players.PlayerAdded:Connect(function() 
    local Seat = script.Parent
    local humanoid = nil
    local function sat()
        if humanoid == nil then
            humanoid = Seat.Occupant
            return
        end
    local hum = Seat.Occupant
    local char = hum.Parent 
    local plr = game.Players:GetPlayerFromCharacter(char) 

        if plr then
            wait(3)
            game:GetService("ReplicatedStorage"):WaitForChild("RemoteEvent"):FireClient(plr) 
            humanoid = nil
        end
    end

    Seat:GetPropertyChangedSignal("Occupant"):Connect(sat)
end)

I just removed Line 09 because "humanoid" was already the "Seat.Occupant"

game.Players.PlayerAdded:Connect(function() 
    local Seat = script.Parent
    local humanoid = nil
    local function sat()
        if humanoid == nil then
            humanoid = Seat.Occupant
            return
        end
    local char = humanoid.Parent --Changed to "Humanoid" instead of "hum"
    local plr = game.Players:GetPlayerFromCharacter(char) 

        if plr then
            wait(3)
            game:GetService("ReplicatedStorage"):WaitForChild("RemoteEvent"):FireClient(plr) 
            humanoid = nil
        end
    end

    Seat:GetPropertyChangedSignal("Occupant"):Connect(sat)
end)

Many thanks to BestCreativeBoy for giving me most of the correct code. And TTChaos For helping too.

AnonymousPermalink

This discussion is preserved as it was. New answers, comments, and votes are closed.