Why is this script not working, its to do with variables?

Hello.

The problem is that part.Parent is actually the character of a player, not the player.

So, you must use the GetPlayerFromCharacter() function. It will get the player from its character, part.Parent.

Also, note that anything can touch a part, not only players, so you have to have an if statement checking if the part touched was a player.

Recommendations:

• Put "local" before declaring a function as it makes it local to its scope, similar to a local variable.

• Put "local" before declaring a variable as it also makes it local to its scope.

• You don't need a connection variable for the connection.

• Use "connect" with an uppercase "C" as "connect" with a lowercase "C" is deprecated. It is never a good idea to use deprecated functions.

Fixed Script:

local bin = script.Parent

local function onTouched(part)
    local plr = game.Players:GetPlayerFromCharacter(part.Parent)
    
	if plr then
		-- Your Code Here
	end
end

bin.Touched:Connect(onTouched)