Scripting HelpersARCHIVE
A little piece of Roblox history. Preserved for everyone, one question at a time.Read about the archive →
All questions/Question #103301
✓ ANSWER ACCEPTED

Updating Cash GUI script not updating when leaderstats value changes?

Asked 252 views1 answers

So i made a leaderstats script and a gui that shows your leaderstats value, but for some reason it dosent update and i dont know why, here is the leaderstats script 

game.Players.PlayerAdded:connect(function(player)
local leaderstats = Instance.new("Folder")
leaderstats.Name = "leaderstats"
leaderstats.Parent = player

local money  = Instance.new("IntValue")
money.Name = "Cash"
money.Parent = leaderstats
money.Value = 0

local crops  = Instance.new("IntValue")
crops.Name = "Crops"
crops.Parent = leaderstats
crops.Value = 100

local level  = Instance.new("IntValue")
level.Name = "Level"
level.Parent = leaderstats
level.Value = 0

end)

and here is my gui script

local player = game:GetService("Players").LocalPlayer
local cash = player.leaderstats.Cash.Value
  script.Parent.Text = math.floor(cash)
	
	cash.Changed:Connect(function()
		script.Parent.Text = math.floor(cash)
	end)
Anonymous

1 answer

✓ Accepted answer

Problems:

  • You put a .Value after getting the cash inside leaderstats.

  • Text requires a string, not a number.

Solutions:

  • Remove the .Value after defining the player's cash as Changed is an event of an instance, not a number (IntValue's value).

  • Use the tostring() function that converts a number into a string.

Recommendations:

  • Use WaitForChild() to make sure the leaderstats and cash have been created by the other script.

  • Remove math.floor() as you do not need to use them since IntValue's automatically round numbers to the nearest whole number.

Fixed Script:

local player = game:GetService("Players").LocalPlayer
local cash = player:WaitForChild("leaderstats"):WaitForChild("Cash")
script.Parent.Text = tostring(cash.Value)

cash.Changed:Connect(function()
	script.Parent.Text = tostring(cash.Value)
end)
AnonymousPermalink

This discussion is preserved as it was. New answers, comments, and votes are closed.